Collation problem and null error with DownloadCount #524

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@FilipDeVos

I fixed an error around the DownloadCount field in the Packages table.

DownloadCount had an incorrect casing in the UpdateStatisticsJob class. This caused a crash on a case sensitive SQL Server install

Regards,

Filip De Vos

@Haacked
NuGet member

:shipit:

@akoeplinger

The second issue (DownloadCount returns NULL) was fixed in 513f257.

@Haacked
NuGet member

Ah! Thanks. I've been out of it for a while. Want to send a new pull request with just the other fix?

@Haacked
NuGet member

You can actually update this PR by doing a force push to your master.

@FilipDeVos

Will take care of it at lunch time

@Haacked
NuGet member

Great!

@FilipDeVos FilipDeVos Fixed casing of DownLoadCount to DownloadCount so it is consistent wi…
…th the field name. This is required for proper functioning on a SQL Server with collation Latin_General_BIN.
7b71fbf
@pranavkm pranavkm added a commit that referenced this pull request Aug 27, 2012
@pranavkm pranavkm * Tweaking UpdateStatisticsJob to update PackageRegistrations conditi…
…onally

* Fixing collation issue in DownloadCount column. Fies #524
8523bb2
@jeffhandley jeffhandley was assigned Sep 5, 2012
@akoeplinger

I guess this PR should be closed now that the problem is fixed in 8523bb2?

@jeffhandley jeffhandley closed this Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment