New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License storage related methods extracted into their own class #6674

merged 17 commits into from Dec 5, 2018



agr commented Nov 16, 2018

Progress on #6533. Addresses NuGet/Engineering#1884.

Extracted the license-related methods into their own storage abstraction class, so it can be used on its own in Orchestrator.

Had to pretty much rewrite on of the StorageDependentFacts tests to accommodate the change. Need to confirm with @joelverhagen that I understood the intention properly.

agr added some commits Nov 15, 2018

Extracted license-related storage code into its own class with its ow…
…n interface, update the DI configuration.
Moved the RevalidationStateService into StorageDependent list, added …
…its own connection string to the configuration.

Need to test that it still works.

Please fix the connection string name. Other than that, looks good! :)


This comment has been minimized.


agr commented Nov 20, 2018

Need to update the deployment configuration to include new configuration key.

agr added some commits Nov 21, 2018

Moved license file extraction code to CoreLicenseFileService.
Moved some test utilities to Core test project to enable testing moved code.

This comment has been minimized.


agr commented Nov 29, 2018

OK, this comes to its final. Need another round of reviews. PR for configuration updates is out.

@agr agr merged commit 8500015 into dev Dec 5, 2018

3 checks passed

NuGetGallery - CI #46256 succeeded
NuGetGallery - Queue NuGetDeployment CI #46257 succeeded
license/cla All CLA requirements met.

@agr agr deleted the agr-licf-refac branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment