New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display License file from blob storage/local files #6675

Merged
merged 7 commits into from Dec 4, 2018

Conversation

@zhhyu
Contributor

zhhyu commented Nov 16, 2018

With given package, we show the license content from blob storage.
Fix: #6518

@zhhyu zhhyu changed the title from Display License file from blob storage to Display License file from blob storage/local files Nov 21, 2018

/// <summary>
/// This interface is used to get the license file path.
/// </summary>
public interface ILicenseFileFlatContainerService

This comment has been minimized.

@skofman1

skofman1 Dec 4, 2018

Contributor

ILicenseFileFlatContainerService [](start = 21, length = 32)

I would keep the interface more general: IFlatContainerService
Because you will be accessing more files from flat container for icons and readme and will need to add more methods here.

@agr

agr approved these changes Dec 4, 2018

LGTM

@zhhyu zhhyu merged commit 12b0850 into dev Dec 4, 2018

3 checks passed

NuGetGallery - CI #46211 succeeded
Details
NuGetGallery - Queue NuGetDeployment CI #46212 succeeded
Details
license/cla All CLA requirements met.
Details

@zhhyu zhhyu deleted the license-file-redirect branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment