New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller should redirect to licenses.nuget.org with license expression #6726

Merged
merged 1 commit into from Dec 6, 2018

Conversation

@zhhyu
Contributor

zhhyu commented Dec 5, 2018

Controller should redirect to licenses.nuget.org with license expression.

@zhhyu zhhyu changed the title from controller should redirect to licenses.nuget.org with license expression to Controller should redirect to licenses.nuget.org with license expression Dec 5, 2018

@agr

agr approved these changes Dec 6, 2018

@zhhyu zhhyu self-assigned this Dec 6, 2018

@zhhyu zhhyu added this to the S145 - 2018.11.26 milestone Dec 6, 2018

@@ -677,6 +677,11 @@ public virtual async Task<ActionResult> License(string id, string version)
return HttpNotFound();
}
if (!string.IsNullOrWhiteSpace(package.LicenseExpression))
{
return Redirect(LicenseExpressionRedirectUrlHelper.GetLicenseExpressionRedirectUrl(package.LicenseExpression));

This comment has been minimized.

@chenriksson

chenriksson Dec 6, 2018

Member

Do we have monitoring for licenses.nuget.org?

This comment has been minimized.

@zhhyu

zhhyu Dec 6, 2018

Contributor

Yeah, I think we have some kinds of monitoring for "license.nuget.org".

@zhhyu zhhyu merged commit fe6fd30 into dev Dec 6, 2018

3 checks passed

NuGetGallery - CI #46362 succeeded
Details
NuGetGallery - Queue NuGetDeployment CI #46363 succeeded
Details
license/cla All CLA requirements met.
Details

@zhhyu zhhyu deleted the zhhyu-license-exp-url branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment