Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Token scanning-Phase 1-4] Audit at Gallery #7715

Merged
merged 7 commits into from Dec 4, 2019

Conversation

@zhhyu
Copy link
Contributor

zhhyu commented Dec 2, 2019

Audit the API key revocation at Gallery. Test locally against Blob storage and Local files.

Handle: NuGet/Engineering#2776

Copy link
Contributor

skofman1 left a comment

🕐

Copy link
Contributor

shishirx34 left a comment

See my comment on the shims.. you will need to actually add revocation source to the audit logs.

Copy link
Contributor

skofman1 left a comment

:shipit:

Copy link
Contributor

shishirx34 left a comment

I recommend you to deploy and verify this change to DEV before merging.

@zhhyu zhhyu force-pushed the zhhyu-ApiKey-Audit branch from 0508ae8 to bddb6af Dec 4, 2019
@zhhyu zhhyu merged commit ebac7bb into dev Dec 4, 2019
2 checks passed
2 checks passed
NuGetGallery - CI #65827 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.