Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the "USNC-Preview" "region" for functional tests #7719

Merged
merged 2 commits into from Dec 3, 2019

Conversation

@agr
Copy link
Contributor

agr commented Dec 3, 2019

Progress on NuGet/Engineering#1912

Need to be able to run the functional tests against the app service. For that, new "region" is introduced, this change, extends the test parameter validation to include that new region. The main change is in the functional test configuration.

@agr agr changed the title Adding the USNC-Preview region for functional tests Adding the "USNC-Preview" "region" for functional tests Dec 3, 2019
Copy link
Member

joelverhagen left a comment

nit: We use all uppercase USNC-PREVIEW elsewhere. maybe stick to that?

@zhhyu
zhhyu approved these changes Dec 3, 2019
@agr agr merged commit 732761a into dev Dec 3, 2019
2 checks passed
2 checks passed
NuGetGallery - CI #65741 succeeded
Details
license/cla All CLA requirements met.
@agr agr deleted the agr-as-ft branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.