Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor app service related changes #7803

Merged
merged 44 commits into from Jan 10, 2020
Merged

Minor app service related changes #7803

merged 44 commits into from Jan 10, 2020

Conversation

@agr
Copy link
Contributor

agr commented Jan 9, 2020

Renamed a variable and a method to emphasize their relation to cloud service infrastructure (not the cloud hosting in general).
Removed duplicate code that figured out machine name.
Added <applicationInitialization> section to the web.config.

agr added 30 commits Nov 14, 2019
@@ -23,7 +24,7 @@ public class ConfigurationService : IGalleryConfigurationService
protected const string ServiceBusPrefix = "AzureServiceBus.";
protected const string PackageDeletePrefix = "PackageDelete.";

private bool _notInCloud;
private bool _notInCloudService;

This comment has been minimized.

Copy link
@joelverhagen

joelverhagen Jan 9, 2020

Member

Hahahaha, this is an awesome delta.

This comment has been minimized.

Copy link
@agr

agr Jan 9, 2020

Author Contributor

Well, it's the actual meaning of the variable: if cloud service API is available. We would be able to drop it completely once we are off cloud services.

<applicationInitialization>
<add initializationPage="/"/>
<add initializationPage="/api/health-probe"/>
</applicationInitialization>

This comment has been minimized.

Copy link
@shishirx34

shishirx34 Jan 10, 2020

Contributor

who uses these? internal load balancer?

This comment has been minimized.

Copy link
@agr

agr Jan 10, 2020

Author Contributor

First one is added mostly to align with the search service, and the second one is watched at least by the internal load balancer, yes.

@agr agr merged commit c59ced8 into dev Jan 10, 2020
2 checks passed
2 checks passed
NuGetGallery - CI #66926 succeeded
Details
license/cla All CLA requirements met.
Details
@xavierdecoster xavierdecoster deleted the agr-appservice branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.