Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuspec file reference incorrectly lists minClientVersion as an element rather than attribute #1450

Closed
duckfist opened this issue May 22, 2019 · 3 comments

Comments

@duckfist
Copy link

commented May 22, 2019

On the page that describes the .nuspec File Reference, the description of "minClientVersion" is listed under the section titled "Optional metadata elements". However, minClientVersion is an XML attribute of the "metadata" XML element, and not an XML element in an of itself.

For a newbie reading the article as-is, one might try adding tags named <minClientVersion>, only to have the nuget pack command return errors, before eventually realizing that it's not actually a valid tag. I'd suggest making another subheading somewhere that describes what the metadata element is, and underneath it describe possible attributes, such as minClientVersion.

Note that this is a duplicate of #607, which has been closed, yet it has not actually been solved.

Thank you!!

@Mikejo5000 Mikejo5000 added the doc-bug label Aug 8, 2019

@Mikejo5000

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@nkolev92 Nikolche, does this seem like a good change to docs.

@nkolev92

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Yup, the OP is correct.

The minClientVersion belongs on the metadata element:

Example

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/01/nuspec.xsd">
    <metadata minClientVersion="100.0.0.1">
        <id>dasdas</id>
        <version>2.0.0</version>
        <title />
        <authors>dsadas</authors>
        <owners />
        <requireLicenseAcceptance>false</requireLicenseAcceptance>
        <description>My package description.</description>
    </metadata>
    <files>
        <file src="content\one.txt" target="content\one.txt" />
    </files>
</package>
@Mikejo5000

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

@nkolev92 Thanks, updating doc

@Mikejo5000 Mikejo5000 closed this in 0c4e3fa Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.