Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix issue when project filenames contains whitespaces #1093

Merged

Conversation

kwlin
Copy link
Contributor

@kwlin kwlin commented Mar 5, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

When the project file name contains whitespaces then NuKeeper fail to restore/remove & add nuget packages.

🆕 What is the new behavior (if this is a feature change)?

NuKeeper will execute dotnet restore/remove & add commands with quotations around project file names

💥 Does this PR introduce a breaking change?

nop

🐛 Recommendations for testing

  • Added unittests
  • Add a project file name with whitespaces.

📝 Links to relevant issues/docs

see #1091

🤔 Checklist before submitting

  • All projects build
  • Relevant documentation was updated

@kwlin
Copy link
Contributor Author

kwlin commented Mar 9, 2021

@MarcBruins what can I do or help to finish this PR? :)

@stale
Copy link

stale bot commented Jun 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 7, 2021
@stale stale bot closed this Jun 28, 2021
@msallin msallin reopened this Sep 20, 2021
@stale stale bot removed the wontfix label Sep 20, 2021
@msallin
Copy link
Member

msallin commented Sep 20, 2021

@kwlin can you please rebase the branch on the latest master?

@msallin msallin self-assigned this Sep 20, 2021
@skolima skolima merged commit fd7b5e5 into NuKeeperDotNet:master Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants