Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Added support for "only" mode in Test runners #333

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@bksahu
Copy link
Member

commented Apr 5, 2019

Fixed #320

Thank your for contributing to Nuitka!

!! Please check that you select the develop branch (details see below link) !!

Before submitting a PR, please review the guidelines:
https://github.com/kayhayen/Nuitka/blob/master/CONTRIBUTING.md

What does this PR do?

Why was it initiated? Any relevant Issues?

PR Checklist

  • Correct base branch selected? develop for new features and bug fixes too. If it's
    part of a hotfix, it will be moved to master during it.
  • All tests still pass. Check the developer manual about Running the Tests. There
    are Travis tests that cover the most important things however, and you are
    welcome to rely on those, but they might not cover enough.
  • Ideally new features or fixed regressions ought to be covered via new tests.
  • Ideally new or changed features have documentation updates.
@@ -121,6 +121,9 @@
search_mode=search_mode,
needs_2to3=needs_2to3,
)

if search_mode.abortIfExecuted():
break

This comment has been minimized.

Copy link
@kayhayen

kayhayen Apr 5, 2019

Member

I hate how this has to modify every usage, but I accept it, because it's my fault, since the skipping dialog is part of using the search mode too, right now. One day, using the search mode, should be more common code, and this only be in one or two places max.

@kayhayen kayhayen merged commit d800032 into Nuitka:develop Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bksahu bksahu deleted the bksahu:testing-only branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.