Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Quality: Fixed the TypeError in autoformat #336
After rebasing I was getting another
Thank your for contributing to Nuitka!
!! Please check that you select the develop branch (details see below link) !!
Before submitting a PR, please review the guidelines:
What does this PR do?
Why was it initiated? Any relevant Issues?
This was during a commit, right? Because I think the code is supposed to be a
That said, for non-utf8 code, we are going to have a hard time this way... and maybe, the
@bksahu You are compensating in your change for the difference bytes from git, unicode from filesystem, when you write the file. But I think that "old_code" is also later compared, and again that issue will be there.
So I am thinking, instead of converting back and forth, make sure to write the file with
Always make sure to solve your data problems at the inception. So reading the files as "unicode" has no value in here, as we will have to know the encoding, and limit ourselves, so e.g. no test can have latin1 anymore. To copy, compare, we can work with bytes. Then black, isort, and friends can deal with it when reading from the file.
Do you get me there?