Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize built-in "max" and "min" #442

Open
wants to merge 11 commits into
base: develop
from

Conversation

@bksahu
Copy link
Member

commented Jun 24, 2019

What does this PR do?

This is a WIP. Optimizes "max" and "min" built-in

Why was it initiated? Any relevant Issues?

#232

PR Checklist

  • Correct base branch selected? develop for new features and bug fixes too. If it's
    part of a hotfix, it will be moved to master during it.
  • All tests still pass. Check the developer manual about Running the Tests. There
    are Travis tests that cover the most important things however, and you are
    welcome to rely on those, but they might not cover enough.
  • Ideally new features or fixed regressions ought to be covered via new tests.
  • Ideally new or changed features have documentation updates.

@bksahu bksahu force-pushed the bksahu:optimize_min_max branch from 4d94757 to 67bd49b Jun 29, 2019

@@ -911,6 +914,114 @@ def wrapEvalBuiltin(source, globals_arg, locals_arg, source_ref):
)


def max_extractor(node):
@calledWithBuiltinArgumentNamesDecorator
def wrapMaxBuiltin(source, source_ref):

This comment has been minimized.

Copy link
@bksahu

bksahu Jul 1, 2019

Author Member

PyLint is complaining due to the unused variable source. However, it is required in the Paramer Specs to pass argument in the wrap function:

result = builtin_class(*args_list, source_ref=node.getSourceReference())

Should I supress the Pylint error?

@kayhayen kayhayen added this to Review in progress in Planning Jul 1, 2019

@kayhayen kayhayen force-pushed the Nuitka:develop branch from 113e470 to f3367de Jul 8, 2019

@bksahu bksahu force-pushed the bksahu:optimize_min_max branch from 0c67f1a to 8883ce3 Jul 16, 2019

@bksahu bksahu force-pushed the bksahu:optimize_min_max branch from bcc4575 to 915e726 Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.