Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI Standalone Tests #484

Open
wants to merge 15 commits into
base: develop
from

Conversation

@tommyli3318
Copy link
Member

commented Aug 11, 2019

What does this PR do?

Creates standalone tests for PyPI packages

Why was it initiated? Any relevant Issues?

GSoC2019

PR Checklist

  • Correct base branch selected? develop for new features and bug fixes too.
    If it's part of a hotfix, it will be moved to master during it.
  • All tests still pass. Check the developer manual about Running the Tests.
    There are Travis tests that cover the most important things however, and you
    are welcome to rely on those, but they might not cover enough.
  • Ideally new features or fixed regressions ought to be covered via new tests.
  • Ideally new or changed features have documentation updates.
tommyli3318 added 6 commits Aug 11, 2019
@kayhayen

This comment has been minimized.

Copy link
Member

commented on tests/standalone/DecoratorUsing.py in 9101547 Aug 14, 2019

Using timing of the output as a test method is not allowed. Also, you are making the test slow.

Maybe make it so, that the decorated function should return a different result, but does not.

@kayhayen

This comment has been minimized.

Copy link
Member

commented on tests/standalone/CryptographyUsing.py in 9101547 Aug 14, 2019

Not sure aboujt your terminology there, but output of encryped data is not allowed, because it's not determinstic. You can encrypt and decrypt something and then it's unchanged, that could be a test.

tommyli3318 added 9 commits Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.