Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI Standalone Tests #484

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

@tommyli3318
Copy link
Member

@tommyli3318 tommyli3318 commented Aug 11, 2019

What does this PR do?

Creates standalone tests for PyPI packages

Why was it initiated? Any relevant Issues?

GSoC2019

PR Checklist

  • Correct base branch selected? develop for new features and bug fixes too.
    If it's part of a hotfix, it will be moved to master during it.
  • All tests still pass. Check the developer manual about Running the Tests.
    There are Travis tests that cover the most important things however, and you
    are welcome to rely on those, but they might not cover enough.
  • Ideally new features or fixed regressions ought to be covered via new tests.
  • Ideally new or changed features have documentation updates.
kayhayen
Copy link
Member

kayhayen commented on 9101547 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using timing of the output as a test method is not allowed. Also, you are making the test slow.

Maybe make it so, that the decorated function should return a different result, but does not.

kayhayen
Copy link
Member

kayhayen commented on 9101547 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure aboujt your terminology there, but output of encryped data is not allowed, because it's not determinstic. You can encrypt and decrypt something and then it's unchanged, that could be a test.

@kayhayen kayhayen force-pushed the develop branch 2 times, most recently from fd1fc4e to 6527c36 Dec 20, 2019
@kayhayen kayhayen force-pushed the develop branch 2 times, most recently from 82d2da2 to 2302a22 May 4, 2020
@kayhayen kayhayen force-pushed the develop branch 3 times, most recently from f695482 to bce3f72 Aug 9, 2020
@kayhayen kayhayen force-pushed the develop branch 2 times, most recently from 794f110 to feb35bb Nov 10, 2020
@kayhayen kayhayen added this to In progress in Planning via automation Mar 28, 2021
@kayhayen
Copy link
Member

@kayhayen kayhayen commented Mar 28, 2021

This will be merged once we have the self hosted runners available.

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Apr 1, 2021

I would love to see this merged so I can run these on the openSUSE builds. Can they be disabled by default so they dont effect the github CI? I am usually only a few releases behind, so failures will get noticed reasonably quickly.

@kayhayen
Copy link
Member

@kayhayen kayhayen commented Apr 1, 2021

@jayvdb going to do that then

@kayhayen kayhayen force-pushed the develop branch 2 times, most recently from f7d4527 to 4c51616 Oct 17, 2021
@kayhayen kayhayen force-pushed the develop branch 4 times, most recently from 9b529c7 to cf49632 Nov 18, 2021
@kayhayen kayhayen force-pushed the develop branch 3 times, most recently from 4f06b9c to 3ce69e6 Nov 24, 2021
@kayhayen kayhayen force-pushed the develop branch 7 times, most recently from 4a65697 to fd0f318 Dec 2, 2021
@kayhayen kayhayen force-pushed the develop branch 2 times, most recently from 71feda0 to 9de0571 Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Planning
  
In progress
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants