New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Creative Inventory on Player First Spawn #1808

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Christian7573

Christian7573 commented Jul 18, 2017

I got bored, so I attempted to fix #1786

@sero583

This comment has been minimized.

Show comment
Hide comment
@sero583

sero583 Jul 24, 2017

This change wont fix it imo

This change wont fix it imo

@jonathanpeppers

This comment has been minimized.

Show comment
Hide comment
@jonathanpeppers

jonathanpeppers Jul 25, 2017

Did this used to work fine? Did perhaps the PR here broke it: #518

I haven't used nukkit for a while, and updated to see this issue happening. @sero583 any suggestions on what to do--I can take a stab at it.

jonathanpeppers commented Jul 25, 2017

Did this used to work fine? Did perhaps the PR here broke it: #518

I haven't used nukkit for a while, and updated to see this issue happening. @sero583 any suggestions on what to do--I can take a stab at it.

@sero583

This comment has been minimized.

Show comment
Hide comment
@sero583

sero583 Jul 25, 2017

@jonathanpeppers A research would be good to know when it happens and taking a look at the current inventory sending code, for me it used to happen sometimes but it wasn't really a major issue thats why I didn't reported it anytime. It happened for me sometimes also after gamemode changing.

sero583 commented Jul 25, 2017

@jonathanpeppers A research would be good to know when it happens and taking a look at the current inventory sending code, for me it used to happen sometimes but it wasn't really a major issue thats why I didn't reported it anytime. It happened for me sometimes also after gamemode changing.

@sero583

This comment has been minimized.

Show comment
Hide comment
@sero583

sero583 Jul 25, 2017

Oh yes that change which made the Player variable from protected to public is not good, because plugins can actually edit the variable how they like to.

sero583 commented Jul 25, 2017

Oh yes that change which made the Player variable from protected to public is not good, because plugins can actually edit the variable how they like to.

@jonathanpeppers

This comment has been minimized.

Show comment
Hide comment
@jonathanpeppers

jonathanpeppers Jul 25, 2017

@sero583

Here is how it has been happening for me (this is issue #1786):

  • Wipe the players directory
  • Run Nukkit with defaultgamemode set to creative
  • First player logs in, has inventory as usual
  • Any subsequent player joining has no inventory--this includes if the first players leaves and rejoins

I was finding I could only get the inventory back if I deletes all the player .dat files, and then only the first player could get them.

I have Minecraft: PE 1.1.4 on iOS.

Also, I tried @Christian7573 's code and it seems to work, however I have never worked in this codebase before--so maybe it needs to happen in another place than Player.doFirstSpawn.

jonathanpeppers commented Jul 25, 2017

@sero583

Here is how it has been happening for me (this is issue #1786):

  • Wipe the players directory
  • Run Nukkit with defaultgamemode set to creative
  • First player logs in, has inventory as usual
  • Any subsequent player joining has no inventory--this includes if the first players leaves and rejoins

I was finding I could only get the inventory back if I deletes all the player .dat files, and then only the first player could get them.

I have Minecraft: PE 1.1.4 on iOS.

Also, I tried @Christian7573 's code and it seems to work, however I have never worked in this codebase before--so maybe it needs to happen in another place than Player.doFirstSpawn.

@sero583

This comment has been minimized.

Show comment
Hide comment
@sero583

sero583 Jul 25, 2017

Also Event changes made which shouldn't be made.

sero583 commented Jul 25, 2017

Also Event changes made which shouldn't be made.

@Christian7573

This comment has been minimized.

Show comment
Hide comment
@Christian7573

Christian7573 Jul 28, 2017

Ok, I'll do some research. Also, if you're referring to the weird public / protected change in PlayerEvent, that was something from when I first downloaded nukkit and I undid it in the next commit.

Christian7573 commented Jul 28, 2017

Ok, I'll do some research. Also, if you're referring to the weird public / protected change in PlayerEvent, that was something from when I first downloaded nukkit and I undid it in the next commit.

@augustoeliezer

This comment has been minimized.

Show comment
Hide comment
@augustoeliezer

augustoeliezer Aug 4, 2017

Thanks @Christian7573

See #1842, same fix but add for each user in server.

augustoeliezer commented Aug 4, 2017

Thanks @Christian7573

See #1842, same fix but add for each user in server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment