Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some issues #673

Merged
merged 5 commits into from Apr 18, 2019

Conversation

@Ekultek
Copy link
Collaborator

Ekultek commented Apr 18, 2019

  • Have to have the right version to create an issue
  • Changes the way that issue "identifiers" are created
  • Some minor fixes
adivinaelnombre and others added 3 commits Apr 14, 2019
Docker refactor
… version it will not create an issue, also changes how the identifier is created
@Ekultek

This comment has been minimized.

Copy link
Collaborator Author

Ekultek commented Apr 18, 2019

Also the docker stuff

@NullArray

This comment has been minimized.

Copy link
Owner

NullArray commented Apr 18, 2019

Thought i merged the docker stuff already? Anyway i'll add my review.

Docker/README.md Outdated Show resolved Hide resolved
Copy link
Owner

NullArray left a comment

Why are we getting rid of the README.md in the docker directory. I have referenced that in the main README, with regards to the docker compose stuff.

@NullArray

This comment has been minimized.

Copy link
Owner

NullArray commented Apr 18, 2019

If i am missing something, please let me know. It could be an oversight on my part but i'd like to make sure before i merge it into the master branch.

Ekultek added 2 commits Apr 18, 2019
UPDATED
@Ekultek Ekultek requested a review from NullArray Apr 18, 2019
Copy link
Owner

NullArray left a comment

Thank you for addressing the issue. Approved and merged.

@NullArray NullArray merged commit 94677e7 into master Apr 18, 2019
@Ekultek

This comment has been minimized.

Copy link
Collaborator Author

Ekultek commented Apr 18, 2019

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.