From 963947383404ce12f83131f06295dd170cae0d7d Mon Sep 17 00:00:00 2001 From: Jonathan Lam Date: Fri, 1 Nov 2024 16:30:14 +1100 Subject: [PATCH 1/2] fix: add empty string to valid severities --- pkg/validator/severity.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/validator/severity.go b/pkg/validator/severity.go index 06ab168..042378f 100644 --- a/pkg/validator/severity.go +++ b/pkg/validator/severity.go @@ -6,6 +6,7 @@ import ( ) var validSeveritites = []string{ + "", models.SeverityLow, models.SeverityMedium, models.SeverityHigh, @@ -24,6 +25,7 @@ func ValidateSeverityThreshold(config *models.Configuration) bool { } var validPriorities = []string{ + "", models.PriorityUrgent, models.PriorityImportant, models.PriorityMedium, From 2f7898ce0c84f89a69eef415e601347e297cc198 Mon Sep 17 00:00:00 2001 From: Jonathan Lam Date: Mon, 30 Dec 2024 01:34:01 +1100 Subject: [PATCH 2/2] fix test --- pkg/validator/severity_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/validator/severity_test.go b/pkg/validator/severity_test.go index 11f89c0..6051f01 100644 --- a/pkg/validator/severity_test.go +++ b/pkg/validator/severity_test.go @@ -17,7 +17,7 @@ func TestValidateSeverityThreshold(t *testing.T) { { name: "empty configuration", config: &models.Configuration{}, - expected: false, + expected: true, }, { name: "default configuration", @@ -27,7 +27,7 @@ func TestValidateSeverityThreshold(t *testing.T) { { name: "empty SeverityThreshold", config: &models.Configuration{SeverityThreshold: ""}, - expected: false, + expected: true, }, { name: "SeverityLow",