Skip to content

Conversation

@Fish-Nullify
Copy link
Contributor

@Fish-Nullify Fish-Nullify commented Jun 16, 2023

Description

Added code to enable pattern matching using the ignore_patterns yaml tag. This will be used for detecting glob patterns in the-force and other services.

Linked Issues & PRs

GitHub Issue Linking Docs

Checklist

  • I have added one of the patch, minor, major or no-release labels
  • I have linked an issue from this repository using the Development option
  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have commented my code where I can't make it self-documenting
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@Fish-Nullify Fish-Nullify self-assigned this Jun 16, 2023
@Fish-Nullify Fish-Nullify added the minor feature addition label Jun 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +6.71 🎉

Comparison is base (0d4f2ff) 65.21% compared to head (e8c45b4) 71.92%.

❗ Current head e8c45b4 differs from pull request most recent head e21576d. Consider uploading reports for the commit e21576d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   65.21%   71.92%   +6.71%     
==========================================
  Files           7        8       +1     
  Lines          46       57      +11     
==========================================
+ Hits           30       41      +11     
  Misses         16       16              
Impacted Files Coverage Δ
pkg/validator/validate.go 0.00% <0.00%> (ø)
pkg/parser/defaults.go 100.00% <100.00%> (ø)
pkg/validator/glob.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tim-thacker-nullify
Copy link
Member

lets add validation to the validator package

Copy link
Member

@tim-thacker-nullify tim-thacker-nullify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add validator

@tim-thacker-nullify tim-thacker-nullify added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit 12dd256 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants