Don't depend on en_US.UTF-8 locale #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, create locale with codecvt_utf8 facet on all platforms (even if codecvt_utf8 is deprecated since C++17). There is no guarantee that "en_US.UTF-8" is a supported locale name, so the locale constructor might throw a runtime_error. (See the discussion in the comments to <https://gerrit.libreoffice.org/#/c/62508/> "Add check for en_US.utf8 locale" for a real-live example of issues caused by that.) (And the <codecvt> and <locale> headers apparently need to be included always, regardless of NUMBERTEXT_BOOST.)
|
Many thanks for the fix! László |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, create locale with codecvt_utf8 facet on all platforms (even if
codecvt_utf8 is deprecated since C++17). There is no guarantee that
"en_US.UTF-8" is a supported locale name, so the locale constructor might throw
a runtime_error. (See the discussion in the comments to
https://gerrit.libreoffice.org/#/c/62508/ "Add check for en_US.utf8 locale"
for a real-live example of issues caused by that.)
(And the and headers apparently need to be included always,
regardless of NUMBERTEXT_BOOST.)