New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keyword searches with POST method #5

Closed
SquareBread opened this Issue Aug 21, 2017 · 3 comments

Comments

2 participants
@SquareBread

SquareBread commented Aug 21, 2017

In Firefox I'm have one keyword search bookmark with very specific url: data:text/html,<form%20method="post"%20action="http://www.fansubs.ru/search.php"><input%20type="hidden"%20name="query"%20value="%s"/><script>document.forms[0].submit();</script>. This bookmark is work in address bar, but not work with this extension. Can it possible to fix it?

@NumeriusNegidius NumeriusNegidius changed the title from It's possible to use this extension with non-standard search urls? to Support keyword searches with POST method Aug 21, 2017

@NumeriusNegidius

This comment has been minimized.

Show comment
Hide comment
@NumeriusNegidius

NumeriusNegidius Aug 21, 2017

Owner

Keyword bookmarks for forms using POST method should be supported if the WebExtensions spec (for browser.tabs.create or smilar) supports it.

Owner

NumeriusNegidius commented Aug 21, 2017

Keyword bookmarks for forms using POST method should be supported if the WebExtensions spec (for browser.tabs.create or smilar) supports it.

@SquareBread

This comment has been minimized.

Show comment
Hide comment
@SquareBread

SquareBread Aug 22, 2017

Then, looks like, it's impossible now.

For security reasons, in Firefox, this may not be a privileged URL. So passing any of the following URLs will fail: data: URLs

It's sad. Thanks for the reply.

P.S. Oh, I'm sorry, I didn't know that FF keyword bookmarks support POST method by default and this ridiculous trick with data:url and invisible form isn't needed. But yes, keyword bookmarks with POST not work in Context Search WebExtension.

SquareBread commented Aug 22, 2017

Then, looks like, it's impossible now.

For security reasons, in Firefox, this may not be a privileged URL. So passing any of the following URLs will fail: data: URLs

It's sad. Thanks for the reply.

P.S. Oh, I'm sorry, I didn't know that FF keyword bookmarks support POST method by default and this ridiculous trick with data:url and invisible form isn't needed. But yes, keyword bookmarks with POST not work in Context Search WebExtension.

@NumeriusNegidius

This comment has been minimized.

Show comment
Hide comment
@NumeriusNegidius

NumeriusNegidius Sep 4, 2017

Owner

This would require the browser.bookmarks API to expose the bookmarks POST state and the form's input parameters. I agree this seems impossible right now.

Thankfully, search engines using POST are rare, since it is not what POST is intended for.

I'm closing this issue for now since it is kind of an edge case and I doubt Mozilla will ever expose this information in browser.bookmarks.

Owner

NumeriusNegidius commented Sep 4, 2017

This would require the browser.bookmarks API to expose the bookmarks POST state and the form's input parameters. I agree this seems impossible right now.

Thankfully, search engines using POST are rare, since it is not what POST is intended for.

I'm closing this issue for now since it is kind of an edge case and I doubt Mozilla will ever expose this information in browser.bookmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment