Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validation condition #8

Conversation

@slava-v
Copy link
Collaborator

commented May 22, 2018

Fixed validation condition based on the issue #7 reported.
Restored indent character for lines added before.

@Nylle

Nylle approved these changes May 22, 2018

Copy link
Owner

left a comment

I'd recommend to wrap indentation changes or other formatting in a separate commit from the actual fix to make reviewing easier next time.

@slava-v

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2018

@Nylle ,

sorry, I didn't mean to make any changes to formatting. I am using spaces as indentation character and did not notice there were tabs as indents in file.

I am going to fix this in a next commit

@slava-v

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2018

@Nylle , oh... i forgot, this commit, along with other fixes, is reverting previous indentation changes made by me back to tab character (that is used in the project).

It is, however, conflicting with PSR-2 that states: use 4 spaces as indentation instead of tabs.
I would suggest adding this in the todo list :)

@slava-v slava-v merged commit 2c99743 into Nylle:master Jun 14, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Nylle

This comment has been minimized.

Copy link
Owner

commented Jun 14, 2018

Hey @slava-v, thanks for your contributions to this project.

I don't really mind which indentation character is used and how many, as long as the code is still readable. Even mixed is fine for me. Bickering about such minor things just drives people apart. So if you feel it would be better to change these things to follow guidelines, you're welcome to. I don't do PHP anymore so I won't be active here anyway.

Thanks again for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.