Fix the Uguu uploader and SICP crash on no auth #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have no idea whether
Host.Type.POMF
andHost.Type.UGUU
should really be called after pomf and uguu; I'm too late to the pomf.se party to know who was the first or what was the standard back then. However, pomf.cat and uguu.se seem to be based on a single codebase (and both usefiles[]
notfile
), while sicp.me is different (usesfile
). So maybe the enum constants should be renamed.Also, in uguu.se
gyazo
andtext
response types are synonyms, but I putgyazo
in to be consistent with the pomf.cat definition.Also, it seems like hostings supported don't exhibit the weird behavior described in the
extractUrl
function, so maybe it should be ditched altogether.