Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Oct 31, 2025

fixes #88

Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet baywet requested review from a team as code owners October 31, 2025 14:47
@baywet baywet self-assigned this Oct 31, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer some of this content move to the README.


Users SHALL refrain from using additional capabilities offered by the tool's JSONPath implementation to avoid any interoperability issues with their Overlay Documents.

In case the tool being use is not fully compliant with RFC9535, users MIGHT have to update some JSONPath query expressions to accommodate for the implementation in use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this statement is needed / appropriate. When a tool doesn't comply with this spec, I think it would be better to recommend that users find a compliant tool than adjust their usage to fit the non-compliant tool.

Comment on lines +292 to +306

### Example of updates to JSONPath

This example JSONPath query expression:

```jsonpath
$.paths.*.get.parameters[?@.name=='filter' && @.in=='query']
```

Might require additional optional parenthesis with some implementations like so:

```jsonpath
$.paths.*.get.parameters[?(@.name=='filter' && @.in=='query)']
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too seems inappropriate for the spec, though I agree it is useful information. Could we put this in the README instead, as a subsection of "Tools that Support Overlays"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also considered putting this as an appendix in the beginning of writing this. But since I have parts that are normative above, I put it in the full specification. Maybe a better approach would be to keep the informational parts and the example as an appendix, and get rid of the normative parts of this section?

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with a few minor suggestions


In case the tool being use is not fully compliant with RFC9535, users MIGHT have to update some JSONPath query expressions to accommodate for the implementation in use.

### Example of updates to JSONPath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this a restriction and not an "update" 😎

This whole section should rather go into the README, as proposed by @mikekistler.

baywet and others added 2 commits October 31, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wildcard JSONPath example in spec text seems incorrect

3 participants