Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create labo.yml #568

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@pfabry
Copy link
Contributor

commented Aug 29, 2019

Adding yml file for LABO ontology.

Create labo.yml
configuration file for LABO, ontology for for informational entities about laboratory tests prescriptions and reports.
@jamesaoverton

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Thanks for the PR. There are two problems that have to be fixed before we can merge:

  1. The labo.owl PURL must point to a file in RDF/XML format (see Principle 2). It currently points to a GitHub HTML page for a file. That could be fixed by pointing to the "raw" file at https://raw.githubusercontent.com/OpenLHS/LABO/master/LABO.owl. However that file is in OWL Functional syntax. It's better for the published versions of the ontology to be in RDF/XML, which can be read by general RDF tools and not just OWL tools.

  2. It's also important for the published file to have a version IRI that will be maintained with a PURL. See Principle 4.

@jamesaoverton jamesaoverton referenced this pull request Aug 29, 2019
1 of 3 tasks complete
Update labo.yml
Added correct link to the RDF/XML version
@pfabry

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@jamesaoverton

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

I'll merge this, but I have two suggestions:

  1. You should include your CC-BY 4.0 license in the published OWL file
  2. I recommend using the GitHub Releases mechanism for publishing releases, rather than just a folder in the repository

@jamesaoverton jamesaoverton merged commit 5d1912e into OBOFoundry:master Sep 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.