Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] barcodes: controller use the elaphe lib to generate barcode #529

Closed
wants to merge 3 commits into from
Closed

[IMP] barcodes: controller use the elaphe lib to generate barcode #529

wants to merge 3 commits into from

Conversation

jefmoura
Copy link
Member

Description of the issue/feature this PR addresses:
There is a framework to generate barcode, useful in many cases, e.g. if I want to generate Aztec/DataMatrix/Pharmacode barcode or many other types, I have these options in the elaphe library to use. The elaphe is a python binding of Barcode Writer In Pure PostScript. This framework provides a lot of settings to customize and create a barcode, just passing this information as options in the generating method.

Current behaviour before PR:
The current barcode generating method in Odoo uses the Reportlab and if I want to generate a Data Matrix code I need to update the Reportlab library to 3.3.0 version, but if I want to change the version/format I can't because it doesn't provide these options. This is only one of much more examples that we can find.

Desired behaviour after PR is merged:
Keep the current behaviour only adding more settings and options of barcode types, initially.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@jefmoura jefmoura changed the title Barcode elaphe [IMP] barcodes: controller use the elaphe lib to generate barcode Aug 15, 2016
@jefmoura
Copy link
Member Author

jefmoura commented Aug 22, 2016

Hi @antespi @dreispt
I created this PR based on another PR that I have done on Odoo repository #13085.
If someone can check, I think these changes are useful for community.
Thanks!

@StefanRijnhart
Copy link
Member

Hi @jefmoura, thank you for taking this initiative. However, it is out of scope for OCB IMHO. We also strife to be 'stable' although we may include bugfixes that require a module upgrade. But injecting new Python dependencies is quite something else. I am sorry to learn from the upstream PR that Odoo won't take this either.
👎 therefore.

@jefmoura
Copy link
Member Author

Ok @StefanRijnhart
Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants