[8.0][FIX] account_asset: Do not include inactive asset lines on asse…

[Daniel-CA]

Description of the issue/feature this PR addresses:
Not reported
Current behavior before PR:
Inactive asset lines are computed on asset analysis report
Desired behavior after PR is merged:
Do not include inactive asset lines on asset analysis report

odoo#16092

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[pedrobaeza]

IMO the report should include all assets, but let's see what Odoo says

[Daniel-CA]

Thanks @pedrobaeza

[StefanRijnhart]

Agree with @pedrobaeza: if there are depreciation lines, they should be shown even for inactive assets.

[Daniel-CA]

Thanks for your reply @StefanRijnhart
But let me give my view about this issue. In my opinion the main problem is when the asset's source invoice is changed, it inactivates the previous asset and creates a new one with his own depreciation lines, so we have both depreciation lines computed in the analysis report and I think this is incorrect because the information is duplicated in this case. Moreover the user is not known that a "new" active has been generated even if the previous one has already posted lines.

[pedrobaeza]

But then the bug is because canceling the invoice doesn't remove the asset. In version 9 it's done this way.

[Daniel-CA]

But you can not remove the asset, it could have posted depreciation lines linked to the account moves. In this case the invoice should not be able to be cancelled.

I have been reviewing v9 code as @pedrobaeza says, but I see a similar code only moved to another object:

    def action_move_create(self):
        result = super(AccountInvoice, self).action_move_create()
        for inv in self:
            if inv.number:
                asset_ids = self.env['account.asset.asset'].sudo().search([('invoice_id', '=', inv.id), ('company_id', '=', inv.company_id.id)])
                if asset_ids:
                    asset_ids.write({'active': False})
            inv.invoice_line_ids.asset_create()
        return result

Moreover, I just want to add an easy solution for the asset report, more than start changing the asset code and how it works.

[pedrobaeza]

Sorry, you're right, assets become inactive, but then again your statement is not correct. You need to show depreciation lines already posted, even for inactive assets. With this, you're hiding them.

[pedrobaeza]

As stated upstream, the bug is not correct, so I close.

[Daniel-CA]

Hi @pedrobaeza,
But the code was changed to show depreciation lines already posted. Not posted lines are computed in the analysis report even if they are in a cancelled asset, and this is a bug imho.

[pedrobaeza]

OK, I didn't see the change, but why don't you say this to Odoo also? They can accept this change. I reopen anyway.

[pedrobaeza]

@StefanRijnhart, what do you think about the new code?

[Daniel-CA]

Hi @pedrobaeza,
Ok, I will post it too in the Odoo branch, thanks for reply.