Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] sms #1684

Merged
merged 1 commit into from Jan 14, 2019
Merged

[12.0][MIG] sms #1684

merged 1 commit into from Jan 14, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

#NothingToDo

It's an auto_install.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow added this to the 12.0 milestone Jan 10, 2019
@pedrobaeza pedrobaeza mentioned this pull request Jan 10, 2019
Closed
pedrobaeza
pedrobaeza requested changes Jan 13, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the other thing untouched and it will be good to go.

pedrobaeza
pedrobaeza approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great, the other one doesn't follow the usual semantic. Thanks for checking that.

@pedrobaeza
Copy link
Member

You can merge when this finishes.

@MiquelRForgeFlow MiquelRForgeFlow merged commit 02c1d5a into OCA:12.0 Jan 14, 2019
@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-sms branch January 14, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MiquelRForgeFlow @pedrobaeza @rvalyi @OCA-git-bot