Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 add modules intrastat_base and intrastat_product (v3) #80

Closed
wants to merge 205 commits into from

Conversation

Projects
None yet
@alexis-via
Copy link

commented May 26, 2015

My third attempt at migrating intrastat_base and intrastat_product from lp:new-report-intrastat to github/OCA

alexis-via added some commits Mar 27, 2011

Add currency in view via a fields.related on report_intrastat_service
Check that company currency is EUR when generating service lines.
Do the rounding work when generating the service lines, not when generating the XML.
Remove unused code.
First alpha version of the new module "l10n_fr_intrastat_product".
First factorisation of common functionnal code between the product and service module (intrastat_common.py) - to be continued.
Some code clean-up in the service module.
More work on full DEB+DES implementation.
Added full support for "transport type" and partial support for the department.
More factorisation between product & service module.
Add date_done field.
More checks.
Converted some fields on report_intrastat_product/service to many2one…
… (fields that are not in the official declaration or never subject to change)

Add copy of department from warehouse to invoice.
Import DEB don't have the partner_vat field
Department can be 99 for Monaco.
Copy tranport and department from report_intrastat_product in XML file
First attempt at adapting the display of fields depending on the type of declaration.
In report_intrastat_product_line, remplace the 2 country fields from …
…string to many2one.

WARNING : this is my last commit before I break everything to re-organise the way intrastat_types are handled and I drop the "Intrastat type" field on invoices.
Complete change of design for intrastat_type !
Now that report_intrastat_product/service object is stored in database, we don't need the legal_intrastat state on invoices any more, because we will be able to create entry lines for DEB for a repair of equipment under warranty without using a legal_intrastat.
Report_intrastat_type is now only required for DEB -> object moved to module l10n_fr_intrastat_product.
For DEB, the button "regenerate lines" only regenerate DEB lines related to invoices.

Renamed intrastat base module, because it doesn't have France-specific parameters any more.

Add demo data.
Renamed some fields
Now manages the specifications of the different procedure_code, for example some info don't need to be declared for some procedure codes.
Ability to enter DEB lines manually
Stat value doesn't exist any more
Tree vue of DEB lines is now identical to Cerfa
"Date done" converted to date + time.
Re-order fields in intrastat_service view
Better interface when entering DEB lines manually.
Commit before I break the main view of intrastat_product.
[FIX] Error in the inherit of view, which can cause a crash in the pr…
…oduct view.

Beta implementation of "Re-generate lines from picking".
[FIX] Check on weight_net instead of weight.
Add pricelist on res_company to compute the stat value
Ability to factorize lines taken from picking
renamed field invoice_uom_id to source_uom_id, because this field is now also used for lines taken from picking
Removed field date_invoice
Removed the label "beta" on the button "generate lines from picking".
- demo data : Add department on warehouse
- removed the use of "user" in the function compute_lines_from_picking
- add a field.function "intrastat department" on picking
- updated the code accordingly : we can now have the department of the picking when generating lines from picking.
- For "generate lines from picking", exclude picking from sale orders…
…/purchase orders that have a shipping policy != 'invoice from the packing'

So it should now only select incoming/outgoing products used for RMAs
Full re-design of intrastat types : probably requires deleting the re…
…port_intrastat_type table, restarting OpenERP and re-creating intrastat types.

Moved intrastat departments from stock.warehouse to stock.location.
Dropped SQL queries ; replaced by traditionnal python code logic. No more need to have one rate per day for invoices with foreign currency.
Add total fiscal value for DEB
More code factorization.
Prepare translation work.
New important feature : ability to exlude invoice lines that have a s…
…pecific tax in it.

For example, this is required for B2C companies, that mustn't put in DEB Export the invoices to EU customers that contain French VAT.
Support for some triangular operations (not all yet)
[FIX] an issue with the type of field of transaction_code on intrastat_type
Add field "Destination/Origin country of the goods" on invoice
Write the value of this field when creating the invoice from the packing
Fix a bug in the computation of the department on picking, and now make it a stored field.
Now able to copy origin/dest country and department on invoice when the invoice is created from SO/PO (before, it was only supported when creating the invoice from the packing).
Moved some demo data from l10n_fr_intrastat_product to intrastat_base
Moved configuration about taxes from company form to tax form
Some modifications to ease v5 -> v6 migration :
- object report_intrastat_code now belong to group account manager
- button functions now return True
Tried to implement the following feature : open attachement form when the XML file as been generated : works on v6, but make client crash en v5 -> code has been commented
DEB lines with procedure code = 25 are now deducted from the fiscal total.
Round invoice total.
Moved the field exclude_from_intrastat_if_present of account.tax from…
… l10n_fr_intrastat_product to intrastat_base, because it should also be used in the module l10n_fr_intrastat_service.

Take this field into account in the generation of DEB lines (module l10n_fr_intrastat_service).
@coveralls

This comment has been minimized.

Copy link

commented May 17, 2016

Coverage Status

Coverage remained the same at 64.507% when pulling 66840b9 on akretion:8.0-add-intrastat-v3 into ff652c7 on OCA:8.0.

Handle scenario where an invoice has products with 0 value (samples f…
…or example) and shipping costs (accessory costs) with value > 0.
@coveralls

This comment has been minimized.

Copy link

commented May 17, 2016

Coverage Status

Coverage remained the same at 64.42% when pulling fa49284 on akretion:8.0-add-intrastat-v3 into ff652c7 on OCA:8.0.

@hbrunn

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

@alexis-via I provided akretion#12 to have a green travis again

hbrunn and others added some commits Jun 2, 2016

@coveralls

This comment has been minimized.

Copy link

commented Jun 12, 2016

Coverage Status

Coverage remained the same at 64.42% when pulling 7a5505f on akretion:8.0-add-intrastat-v3 into ff652c7 on OCA:8.0.

Remove required=1 because we can have intrastat unit that will never …
…be mapped to an odoo unit (will always be set manually)
@coveralls

This comment has been minimized.

Copy link

commented Jun 13, 2016

Coverage Status

Coverage remained the same at 64.42% when pulling 86bc745 on akretion:8.0-add-intrastat-v3 into ff652c7 on OCA:8.0.

alexis-via added some commits Jun 21, 2016

Merge pull request #12 from hbrunn/8.0-add-intrastat-v3
[FIX] this week's ci errors
@hbrunn

This comment has been minimized.

Copy link
Member

commented Sep 15, 2016

@alexis-via is this ready to review?

@alexis-via

This comment has been minimized.

Copy link
Author

commented Sep 15, 2016

@hbrunn yes sure.
It is already used in production by some of our customers.
I know there are some things that @luc-demeyer want to change/update, but we didn't have the time to finish it during the Sorrento code sprint...I hope we will have time to finish during the Odoo Experience sprint.

And by the way, I eventually think that intrastat needs a dedicated OCA repo and that it wasn't such a good idea to propose it to account-financial-reporting...

@hbrunn

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

I think you're right for the dedicated repo. But please lets not tell anyone about it and merge this first. 👍 here

@alexis-via

This comment has been minimized.

Copy link
Author

commented Sep 16, 2016

Mmm, if we decide to have a dedicated repo, we'd better create it now and merge it in the new repo before merging it here I think.

@hbrunn

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

then let's open the new repo. Do we need approval from @OCA/board or can we just push forward?

@sbidoul

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

I'am in favor of a new repo. To follow the procedure, send an email to contribute@odoo-community.org the ask for the creation of the new repo under a PSC to be chosen in the list.

@alexis-via

This comment has been minimized.

Copy link
Author

commented Oct 3, 2016

luc-demeyer and others added some commits Oct 3, 2016

Update README.rst
Rename variables

@alexis-via alexis-via referenced this pull request Oct 11, 2016

Merged

[8.0] Add intrastat v3 #2

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2016

Closing as this should be in OCA/instrastat

@pedrobaeza pedrobaeza closed this Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.