New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] account_fiscal_year #706
Conversation
* Add contributors to README * try to find a FY start date according to the start date from choosen period * Unable to unlink a date_range with type fiscal_year * `fiscal_year` flag readonly * add menu to date_range under accounting section * remove method on object because it's the same as in file * unable to delete with flag 'fiscal_year' but can delete * clean __openerp__.py * account_fiscal_year version number
[MIG] Migrated module 'account_fiscal_year' to V10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small Change
account_fiscal_year/__manifest__.py
Outdated
'category': 'Accounting', | ||
'author': 'Camptocamp SA,' | ||
'Odoo Community Association (OCA)', | ||
'website': 'http://www.camptocamp.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5549e14
to
cc2de25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some small changes.
Damien Crier is from Camptocamp so it shouldn't apear as # Author: Damien Crier
Check this: URL
@@ -0,0 +1,23 @@ | |||
# Author: Damien Crier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should go to 'author' section.
@@ -0,0 +1,24 @@ | |||
# Author: Damien Crier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
@@ -0,0 +1,43 @@ | |||
# Author: Damien Crier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Also, |
I think this module is no longer needed, as now Odoo allows to put variable fiscal years. Or this feature is enterprise only? @fclementic2c can you confirm? |
@pedrobaeza You are right!. If you mean this it's CE. |
Yes, that's it |
@aitorbouzas @pedrobaeza so maybe we should create a menuitem pointing to |
@eLBati yes this module can do that |
@aitorbouzas @pedrobaeza adding refactored |
Closing this one then. |
Depends on [12.0][MIG] date_range #25