Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] account_fiscal_year #706

Closed
wants to merge 11 commits into from

Conversation

rven
Copy link
Contributor

@rven rven commented Oct 2, 2018

Depends on [12.0][MIG] date_range #25

damdam-s and others added 10 commits October 2, 2018 15:40
* Add contributors to README
* try to find a FY start date according to the start date from choosen period
* Unable to unlink a date_range with type fiscal_year
* `fiscal_year` flag readonly
* add menu to date_range under accounting section
* remove method on  object because it's the same as in  file
* unable to delete  with flag 'fiscal_year' but can delete
* clean __openerp__.py
* account_fiscal_year version number
[MIG] Migrated module 'account_fiscal_year' to V10
@rven rven mentioned this pull request Oct 2, 2018
24 tasks
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Change

'category': 'Accounting',
'author': 'Camptocamp SA,'
'Odoo Community Association (OCA)',
'website': 'http://www.camptocamp.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rven Replace URL as per this

@rven rven force-pushed the 12.0-mig-account_fiscal_year branch from 5549e14 to cc2de25 Compare October 2, 2018 20:59
Copy link

@aitorbouzas aitorbouzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small changes.
Damien Crier is from Camptocamp so it shouldn't apear as # Author: Damien Crier
Check this: URL

@@ -0,0 +1,23 @@
# Author: Damien Crier

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should go to 'author' section.

@@ -0,0 +1,24 @@
# Author: Damien Crier

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@@ -0,0 +1,43 @@
# Author: Damien Crier

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@aitorbouzas
Copy link

aitorbouzas commented Oct 11, 2018

Also, date_range is already available in V12 in @OCA server-ux

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 11, 2018
@pedrobaeza
Copy link
Member

I think this module is no longer needed, as now Odoo allows to put variable fiscal years. Or this feature is enterprise only? @fclementic2c can you confirm?

@aitorbouzas
Copy link

@pedrobaeza You are right!. If you mean this it's CE.

@pedrobaeza
Copy link
Member

Yes, that's it

@eLBati
Copy link
Member

eLBati commented Oct 31, 2018

@aitorbouzas @pedrobaeza so maybe we should create a menuitem pointing to account.actions_account_fiscal_year, as the action is present but hidden (shown by an enterprise menu)

@pedrobaeza
Copy link
Member

@eLBati yes this module can do that

@eLBati
Copy link
Member

eLBati commented Oct 31, 2018

@aitorbouzas @pedrobaeza adding refactored account_fiscal_year with #726

@pedrobaeza
Copy link
Member

Closing this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet