[FIX] do_merge now returns a tuple. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
May 10, 2017
astirpe
approved these changes
May 22, 2017
|
Do you know why the Travis error? |
|
@pedrobaeza I do not quite see where the Travis error comes from. The error only occurs when some modules are excluded from testing. And then it fails on invoice sorting, which I feel has nothing to do with the changes proposed here. |
|
the 8.0 build of Travis is read, so unless we fix this all PR on that branch will be red too. |
|
is this the same thing as #268 ? |
|
@gurneyalex yes, regarding module |
astirpe
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_merge method should have a consistent return value. Now we had a crash in a database where account_invoice_merge_purchase was not installed. This was due to this being a new module, and an existing database. But can also happen in databases were purchase is not needed and installed, so auto_install of account_invoice_merge_purchase will not be done.