[9.0] account mass reconcile (migration of account_easy_reconcile and account_advanced_reconcile) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdietrichc2c
force-pushed
the
9.0-account-easy-advanced-reconcile
branch
from
1d98bcc
to
719f8dd
Compare
mdietrichc2c
force-pushed
the
9.0-account-easy-advanced-reconcile
branch
2 times, most recently
from
1a236b7
to
97dbfd0
Compare
mdietrichc2c
changed the title
|
I finished fixing the tests and a view not displaying correctly. |
| get_module_resource('account', 'test', | ||
| 'account_minimal_test.xml'), | ||
| {}, 'init', False, 'test') | ||
| self.rec_history_obj = self.registry('mass.reconcile.history') |
There was a problem hiding this comment.
you can use self.env thus remove the self.cr and self.uid
mdietrichc2c
force-pushed
the
9.0-account-easy-advanced-reconcile
branch
from
efbbcd8
to
6b0c30e
Compare
| @@ -46,7 +45,7 @@ Bug Tracker | |||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/bank-statement-reconcile/issues>`_. | |||
| In case of trouble, please check there if your issue has already been reported. | |||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | |||
| `here <https://github.com/OCA/bank-statement-reconcile/issues/new?body=module:%20account_easy_reconcile%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | |||
| `here <https://github.com/OCA/bank-statement-reconcile/issues/new?body=module:%20account_mass_reconcile%0Aversion:%209.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | |||
There was a problem hiding this comment.
Here is the good news, you can simplify that:
https://github.com/OCA/maintainer-tools/blame/master/template/module/README.rst#L51
|
Almost good, some security model access are not on the right group. Otherwise, a bit of nitpicking. |
|
|
||
| @api.one | ||
| @api.multi |
There was a problem hiding this comment.
note that api.multi is implicit with api.depends
|
👍 Thanks for the fix and the work done here. For me it's ready to be merged. My lasts comments are optional. |
|
👍 |
|
Hi, Thanks for the work ! I've made functional tests and it work for all methods of the module. LGTM 👍 |
tschanzt
pushed a commit
to tschanzt/account-reconcile
that referenced
this pull request
May 10, 2019
Use svg badge for coveralls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to migrate to 9.0 both
account_easy_reconcileandaccount_advanced_reconcile.A few points:
account_mass_reconcile, since both are more often than not used jointly.