Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] account_mass_reconcile_by_sale_line #434

Merged
merged 4 commits into from
Feb 4, 2022
Merged

[14.0][MIG] account_mass_reconcile_by_sale_line #434

merged 4 commits into from
Feb 4, 2022
+190 −0

Conversation

dnplkndll
Copy link

No description provided.

@dnplkndll dnplkndll force-pushed the 14.0-mig-account_mass_reconcile_by_sale_line branch from 066fd04 to 3f34b56 Compare January 22, 2022 16:43
@dnplkndll dnplkndll changed the title draft: 14.0 mig account mass reconcile by sale line draft: [14.0][MIG] account mass reconcile by sale line Jan 22, 2022
@dnplkndll dnplkndll changed the title draft: [14.0][MIG] account mass reconcile by sale line draft: [14.0][MIG] account_mass_reconcile_by_sale_line Jan 22, 2022
@dnplkndll dnplkndll force-pushed the 14.0-mig-account_mass_reconcile_by_sale_line branch from 319ab55 to e90686e Compare January 22, 2022 17:59
@dnplkndll dnplkndll force-pushed the 14.0-mig-account_mass_reconcile_by_sale_line branch from e90686e to b7db0dc Compare January 22, 2022 20:01
@dnplkndll dnplkndll changed the title draft: [14.0][MIG] account_mass_reconcile_by_sale_line [14.0][MIG] account_mass_reconcile_by_sale_line Jan 23, 2022
@AaronHForgeFlow
Copy link

AaronHForgeFlow commented Jan 26, 2022 •
edited
Loading

Hi @dnplkndll can you include this commit? 8eda175
I tried to create a PR to your fork but was not able to do so, that is why I created this other PR #438 I can close it if consider my changes.

The reason is the sale order for kits fail to reconcile because the product is different in the journal items, I think it is still safe, because the sale order line already has the product on it.

@dnplkndll
Copy link
Author

dnplkndll commented Jan 26, 2022 •
edited
Loading

@AaronHForgeFlow got it and gave you access.

@AaronHForgeFlow
Copy link

@dnplkndll Thank you!

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 27, 2022
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests

@AaronHForgeFlow
Copy link

/ocabot migration account_mass_reconcile_by_sale_line

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Feb 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 4, 2022
Closed
6 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-434-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit dc9d877 into OCA:14.0 Feb 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e5ab5ff. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dnplkndll @AaronHForgeFlow @OCA-git-bot @MiquelRForgeFlow