[ADD] business_requirement #2
Conversation
|
This is the new PR which replaces the old one: OCA/project#127 |
|
👍 |
|
@victormartinelicocorp We should merge #1 and then rebase this. Can you have a look there? Also, no need to provide a list of the changed files, thatis the diff already. |
|
#1 merged, @victormartinelicocorp you can fetch and rebase now. |
|
Thanks! |
new file: business_requirement/README.rst new file: business_requirement/__init__.py new file: business_requirement/__openerp__.py new file: business_requirement/data/business_data.xml new file: business_requirement/models/__init__.py new file: business_requirement/models/business.py new file: business_requirement/security/ir.model.access.csv new file: business_requirement/security/security.xml new file: business_requirement/static/description/icon.png new file: business_requirement/static/img/bus_req.png new file: business_requirement/static/img/bus_req_alias.png new file: business_requirement/static/img/bus_req_approved.png new file: business_requirement/static/img/bus_req_cancel.png new file: business_requirement/static/img/bus_req_confirmed.png new file: business_requirement/static/img/bus_req_cust_story.png new file: business_requirement/static/img/bus_req_done.png new file: business_requirement/static/img/bus_req_drop.png new file: business_requirement/static/img/bus_req_module_diag.png new file: business_requirement/static/img/bus_req_tags.png new file: business_requirement/static/img/bus_req_tags2.png new file: business_requirement/static/img/bus_req_tree.png new file: business_requirement/static/img/module_diag.graphml new file: business_requirement/tests/__init__.py new file: business_requirement/tests/test_br.py new file: business_requirement/views/business_view.xml new file: business_requirement/wizards/__init__.py new file: business_requirement/wizards/mail_compose_message.py
victormmtorres
force-pushed
the
0_business_requirement_base
branch
from
6653215
to
da0ea5b
Compare
|
@elicoidal @dreispt Done. Thanks! |
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/ | ||
| project/issues/new?body=module:%20 | ||
| business_requirement%0Aversion:%20 | ||
| 8.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
This might be the line generating the rst error. Remove the line break.
See http://www.silas.net.br/tech/devel/rst.html
modified: business_requirement/README.rst modified: business_requirement/models/business.py
|
@dreispt Thanks! Travis is green :) |
|
|
||
| The set comprises of multiple modules that can be used independently or not: | ||
|
|
||
| =========================================== ==================================== |
There was a problem hiding this comment.
I think this a description for the README.md of the repository, not this module, and it's even automatically done by the module listing bot.
There was a problem hiding this comment.
Thanks for the review :)
I will move that part to the README.md
|
Crop the icon to get the full size instead of keeping a transparent border. |
| result = super(MailComposeMessage, self).default_get( | ||
| cr, uid, fields, context=context) | ||
|
|
||
| # v6.1 compatibility mode |
There was a problem hiding this comment.
This shouldn't go here in this module. If you have found a problem in the composition wizard, put a PR/issue against Odoo/OCB or make a specific patch module that deals with it, but don't insert this in a module about "Business requirements"
There was a problem hiding this comment.
@pedrobaeza Thanks for the advice: we will recheck the methods about message (@duanyp1991 @seb-elico)
|
@victormartinelicocorp @elicoidal When using the module I find it missing a field 'Requested by'. IMHO the system should default me as 'Requested by', but I should have the possibility to change it to someone else. Also, the requested by should become a follower of the business requirement when he's assigned, so that he's on the loop of the updates. |
|
I'm playing with the BI views in v9 right now. Also added a couple of On Fri, Jun 17, 2016 at 3:22 AM, Eric Caudal notifications@github.com
Jordi Ballester Alomar |
If confirmed the user can't modify the first tab (story/scenario/gap) but can still change the second one (Other information). If approved, the user can't change the first and second tab. modified: business_requirement/models/business.py
to be simplify the name to "Categories". Change business requirement "description" to full screen wide. modified: business_requirement/models/business.py modified: business_requirement/views/business_view.xml
added the module in the image path in README for business_requirement base module.
…ml widget on the view. Remove sequence field on the Tree view. Next version will use sequence for the Kanban view. modified: business_requirement/models/business.py modified: business_requirement/views/business_view.xml
|
@elicoidal I modified the comments left. Could you have a check? |
|
👍 |
| states={'draft': [('readonly', False)]} | ||
| ) | ||
| state = fields.Selection( | ||
| selection="_get_states", |
There was a problem hiding this comment.
For future work: use Stages instead of states. The base_stage_state (still a WIP) could be a quick and easy way to do that.
There was a problem hiding this comment.
We will change it now (s/state/stage) in order to avoid migration later.
There was a problem hiding this comment.
There was a problem hiding this comment.
@elicoidal @victormartinelicocorp we can keep it like this since the module is still in WIP. The migration is still needed even if we change the name now. :)
|
👍 I pointed out some nitpicks, but nothing worth blocking a merge. PS: As an experiment, I enabled CodeReviewHub for this repo. Sorry for any noise. |
|
|
|
@dreispt Thanks for the time to review and your advices! This is really appreciated. |
…w guideline and remove not necessary isolated functions. modified: business_requirement/models/business.py
|
👍 |
|
@dreispt @jbeficent @pedrobaeza Thanks for your help and review! |
|
@elicoidal Thanks to you and @victormartinelicocorp! It is a great contribution. |
…nt_base [ADD] business_requirement
…nt_deliverable_categ rebase
new file: business_requirement/README.rst
new file: business_requirement/init.py
new file: business_requirement/openerp.py
new file: business_requirement/data/business_data.xml
new file: business_requirement/models/init.py
new file: business_requirement/models/business.py
new file: business_requirement/security/ir.model.access.csv
new file: business_requirement/security/security.xml
new file: business_requirement/static/description/icon.png
new file: business_requirement/static/img/bus_req.png
new file: business_requirement/static/img/bus_req_alias.png
new file: business_requirement/static/img/bus_req_approved.png
new file: business_requirement/static/img/bus_req_cancel.png
new file: business_requirement/static/img/bus_req_confirmed.png
new file: business_requirement/static/img/bus_req_cust_story.png
new file: business_requirement/static/img/bus_req_done.png
new file: business_requirement/static/img/bus_req_drop.png
new file: business_requirement/static/img/bus_req_module_diag.png
new file: business_requirement/static/img/bus_req_tags.png
new file: business_requirement/static/img/bus_req_tags2.png
new file: business_requirement/static/img/bus_req_tree.png
new file: business_requirement/static/img/module_diag.graphml
new file: business_requirement/tests/init.py
new file: business_requirement/tests/test_br.py
new file: business_requirement/views/business_view.xml
new file: business_requirement/wizards/init.py
new file: business_requirement/wizards/mail_compose_message.py
@pedrobaeza I cannot add the labels in repo: any idea?
Also, no need to provide a list of the changed files, thatis the diff already.
Instead, provide some insight on what changed. In this case, your second comment is the relevant one.
Thanks!
Coverage remained the same at 60.104% when pulling da0ea5b on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Coverage remained the same at 60.104% when pulling 96e15f9 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
@pedrobaeza @jbeficent Could we get a review and work on merging this PR.
It has been a long time now and we are eager to propose a first stable version.
As I'm conducting interviews in gap analysis sessions with end users during this days, I am the one capturing the requirements, and hence I am the one logged as 'created_by'. But I want to reflect that I am creating a requirement that has been requested by another user.
IMHO the system should default me as 'Requested by', but I should have the possibility to change it to someone else. Also, the requested by should become a follower of the business requirement when he's assigned, so that he's on the loop of the updates.
It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:
Appreciation of efforts,
OCA CLAbot
Coverage remained the same at 60.104% when pulling 3ca3293 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
I made a PR with my github account in victor repo which is a fork from this repo.
Both Victor's and my github login are in the ERP.
Can you help us?
Coverage remained the same at 88.043% when pulling a111174 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Coverage remained the same at 88.043% when pulling 1600357 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Some questions have been answered as well in the comments: looking forward to your feedback
BTW: we plan a BI report specific for the BR (BR=>BRD=>BRL with several dimensions and measures)
modules in a separate repo to make use of requirements pivot analysis by
area and artifact https://github.com/Eficent/service_management
On Fri, Jun 17, 2016 at 3:22 AM, Eric Caudal notifications@github.com
wrote: --
Jordi Ballester Alomar
CEO & Founder | Eficent
(+34) 629530707 | jordi.ballester@eficent.com | http://www.eficent.com
Twitter: https://twitter.com/jbeficent_erp | Linkedin:
https://www.linkedin.com/in/jordiballesteralomar
Coverage remained the same at 87.097% when pulling 8c858ee on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Coverage remained the same at 87.097% when pulling 4bfb8ab on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Coverage remained the same at 87.097% when pulling cda7844 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
Coverage remained the same at 87.097% when pulling fb120a1 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
@pedrobaeza @dreispt would you be so kind to help us get an extra +1 and merge this PR?
PS: As an experiment, I enabled CodeReviewHub for this repo. Sorry for any noise.
We will fix simple details and merge the PR.
Coverage remained the same at 86.813% when pulling ba7a4f4 on victormartinelicocorp:0_business_requirement_base into af25af1 on OCA:8.0.
.. |image6| image:: business_requirement/static/img/bus_req_approved.png
Apply for all other images in .rst
Anyway I will update
_compute_...I believe this is being enforced on newer builds.
Effort to get there is small though
See http://www.silas.net.br/tech/devel/rst.html
I will move that part to the README.md
*at the end?So we should have a new sequence generated at copy method if I understand properly
Now, if I create 3 requirements for 2 projects and I try to make a project-specific order in this view, the order will never be respected as project-specific.
IMHO if you want to make the sequence work, do it as it is used in the sales order. That is, create a tree view in the project form, specific to business requirements, and add the handle to that view. Then the sequence will be generated on a per-project basis. You might have duplicates on a sequence between two projects, but that's allright. (same as same sequences for two separate sales orders).
Not sure how you'd use the sequence field in the Kanban view.
Kanban could be per stage with filtering by project or customer.
All in all, no decision made but in this module I wanted to provide the most standard and basic field for later use.
If no consensus on this usage we might reconsider (we do not use it yet because the Kanban view is not yet implemented)
fields.Htmland you won't need to put the widget in views.You can't overwrite totally this method only for making a little change. You have to find a way of getting your behavior without copy/pasting the code.