Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] #208

Merged
merged 2 commits into from
Jul 10, 2017
Merged

[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] #208

merged 2 commits into from
Jul 10, 2017

Conversation

serpentcs-dev1
Copy link
Member

@serpentcs-dev1 serpentcs-dev1 commented Jul 3, 2017 •
edited

Issue:- #184

  • Improved string Reference to "WBS"

  • Improved name_get method

  • Added origin field with text type

@elicoidal @victormartinelicocorp

elicoidal
elicoidal approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@victormartinelicocorp @seb-elico

business_requirement/models/business.py
@@ -40,7 +40,7 @@ def _get_default_company(self):
states={'draft': [('readonly', False)]}
)
ref = fields.Char(
'Reference',
'WBS',
required=False,
readonly=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why r/o?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. I haven't changed it was already there.

But yes, I think read-only should not be there, should I remove?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure as there are some ACL based on status. I dont know if it has an impact so dont modify it here.

@elicoidal elicoidal added this to the 8.0 milestone Jul 3, 2017
victormmtorres
victormmtorres suggested changes Jul 3, 2017
View reviewed changes
business_requirement/models/business.py
@@ -269,7 +270,8 @@ def name_get(self):
result = []
for br in self:
if br.ref:
formatted_name = u'[{}] {}'.format(br.ref, br.description)
formatted_name = u'[{}][{}] {}'.format(br.ref, br.name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshan-serpent What is the point of have twice the br.name? Perhaps you forgot add other field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right. I think It should be like, right?

formatted_name = u'[{}] {}'.format(br.ref, br.name, br.description)

Will do the needful, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure here but if the requirement is fulfilled, this is fine by me.

I want: [WBS][name] Description or [name] Description (if WBS empty)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@serpentcs-dev1
Copy link
Member Author

@elicoidal @victormartinelicocorp Tested on runbot, works as expected.

The test is made with 2 BRs, one with WBS and other without it.

without_wbs
with_wbs

elicoidal
elicoidal approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@elicoidal
Copy link
Contributor

@victormartinelicocorp please review again

@elicoidal elicoidal merged commit 29e0e33 into OCA:8.0 Jul 10, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@serpentcs-dev1
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
ba85334 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019
@serpentcs-dev1
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
f229163 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
pedrobaeza pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@serpentcs-dev1 @pedrobaeza
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
ab7bb03 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
@serpentcs-dev1
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
da0f607 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 24, 2020
@serpentcs-dev1 @Tardo
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
b305434 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@serpentcs-dev1 @victoralmau
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
6e44f28 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@serpentcs-dev1 @victoralmau
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
95ab1bc 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@serpentcs-dev1 @MosabWadea
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
d3ee305 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
AntoniRomera pushed a commit to AntoniRomera/business-requirement that referenced this pull request Jul 4, 2023
@serpentcs-dev1
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
4eb870f 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
NachoAlesLopez pushed a commit to NachoAlesLopez/business-requirement that referenced this pull request Apr 28, 2024
@serpentcs-dev1 @NachoAlesLopez
[8.0]-[BR1030]-[ADD/IMP][Reference field improvements] (OCA#208)
a7f5bbc 
* [8.0][BR1030][ADD][Reference field improvements]

* [IMP]Improved code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

@victormmtorres victormmtorres victormmtorres approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serpentcs-dev1 @elicoidal @victormmtorres