Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] business_requirement_deliverable_categ #4

Merged

Conversation

Projects
None yet
7 participants
@victormmtorres
Copy link
Collaborator

commented Jun 3, 2016


  

"installable": True,
"depends": [
"business_requirement_deliverable",
"project_task_category",

This comment has been minimized.

Copy link
@yostashiro

yostashiro Jun 9, 2016

Member

Where can I find project_task_category?

This comment has been minimized.

Copy link
@elicoidal

elicoidal Jun 10, 2016

Contributor

@yostashiro we still need to push it to project repo
@victormartinelicocorp

  • Can you create a PR for the module to project repo?
  • Can you create a PR for docx report module to the report-engine repo?
  • Can you update the oca_dependencies.txt module accordingly after PR are accepted?

This comment has been minimized.

Copy link
@elicoidal

elicoidal Jun 22, 2016

Contributor

@victormartinelicocorp can you create the PR for project_task_category?

This comment has been minimized.

Copy link
@dreispt

dreispt Jun 22, 2016

Member

Why can't you use the standard task categories (aka Tags)?

This comment has been minimized.

Copy link
@elicoidal

elicoidal Jun 22, 2016

Contributor

@dreispt tags are not report friendly. I do not like the m2m because you cannot filter/report properly.
with a m2o categ like this you can create clean reports for the task type allocated time vs spent.
It would be impossible to achieve with tags (see comment on the topic in #2)

This comment has been minimized.

Copy link
@dreispt

dreispt Jun 22, 2016

Member

OK. I also have the need for an m2o categ_id on Tasks and Issues.
That feature is welcome.
If you don't mind, I would rather have that as a PR for oca/project.

This comment has been minimized.

Copy link
@elicoidal

elicoidal Jun 23, 2016

Contributor

@dreispt We already have m2m tags at BR level. Do you mean you want to add m2m tags at resource line to pre-fill the tasks?
If that is the case, I would suggest a new module depending on br_deliverable and br_project that would add the field and alter the wizard for task creation

If you don't mind, I would rather have that as a PR for oca/project.

What do you mean?

This comment has been minimized.

Copy link
@dreispt

dreispt Jun 23, 2016

Member

I understood that you have a new module project_task_category adding a m2o category field.
I was suggesting for this to be proposed to oca/project.
But please explain if I got that wrong.

This comment has been minimized.

Copy link
@elicoidal

elicoidal Jun 23, 2016

Contributor

This is definitively in our plans (just got too busy as usual).
@victormartinelicocorp can you add it to the list (on top of the docx report engine)?

victormmtorres pushed a commit to victormmtorres/business-requirement that referenced this pull request Aug 8, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 12, 2016

Coverage Status

Coverage remained the same at 90.783% when pulling 4422969 on victormartinelicocorp:2_business_requirement_deliverable_categ into af25af1 on OCA:8.0.

@coveralls

This comment has been minimized.

Copy link

commented Aug 12, 2016

Coverage Status

Coverage remained the same at 90.783% when pulling 747ffdf on victormartinelicocorp:2_business_requirement_deliverable_categ into af25af1 on OCA:8.0.

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2016

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

👍
Make sure to:

  • alter the project_categ module as well based on our previous discussion
  • adapt the br_project wizard accordingly

victor and others added some commits Jun 3, 2016

victor
[FIX] business_requirement_deliverable_categ: Fix new project_categ d…
…ependency from OCA/project repository.

	modified:   business_requirement_deliverable_categ/__openerp__.py
	modified:   business_requirement_deliverable_categ/models/business_requirement_deliverable_categ.py
	modified:   business_requirement_deliverable_categ/views/business_requirement_deliverable_categ.xml
victor
[FIX] business_requirement_deliverable_categ: Travis test_flake8 FAIL.
	modified:   business_requirement_deliverable_categ/__openerp__.py

@victormmtorres victormmtorres force-pushed the victormmtorres:2_business_requirement_deliverable_categ branch from 747ffdf to aab7171 Aug 29, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 29, 2016

Coverage Status

Coverage increased (+0.3%) to 90.991% when pulling aab7171 on victormartinelicocorp:2_business_requirement_deliverable_categ into 8442e3f on OCA:8.0.

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2016

@elicoidal Please review.

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

👍
I will fix the README in separate PR

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 30, 2016

Coverage Status

Coverage increased (+0.3%) to 90.991% when pulling 0051641 on victormartinelicocorp:2_business_requirement_deliverable_categ into 8442e3f on OCA:8.0.

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2016

@coveralls

This comment has been minimized.

Copy link

commented Sep 12, 2016

Coverage Status

Coverage increased (+0.7%) to 91.304% when pulling 18f75f9 on victormartinelicocorp:2_business_requirement_deliverable_categ into 8442e3f on OCA:8.0.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Sep 12, 2016

Coverage Status

Coverage increased (+0.7%) to 91.304% when pulling 18f75f9 on victormartinelicocorp:2_business_requirement_deliverable_categ into 8442e3f on OCA:8.0.

@coveralls

This comment has been minimized.

Copy link

commented Sep 12, 2016

Coverage Status

Coverage increased (+0.7%) to 91.304% when pulling 18f75f9 on victormartinelicocorp:2_business_requirement_deliverable_categ into 8442e3f on OCA:8.0.

victor added some commits Sep 13, 2016

victor
Merge branch '2_business_requirement_deliverable_categ' of git://gith…
…ub.com/elicoidal/business-requirement into elicoidal-2_business_requirement_deliverable_categ

 Conflicts:
	business_requirement_deliverable_categ/__openerp__.py
	business_requirement_deliverable_categ/models/business_requirement_deliverable_categ.py
	business_requirement_deliverable_categ/views/business_requirement_deliverable_categ.xml
victor
Merge branch 'elicoidal-2_business_requirement_deliverable_categ' int…
…o 2_business_requirement_deliverable_categ

@victormmtorres victormmtorres force-pushed the victormmtorres:2_business_requirement_deliverable_categ branch from 18f75f9 to 4a9e812 Sep 13, 2016

@coveralls

This comment has been minimized.

Copy link

commented Sep 13, 2016

Coverage Status

Coverage increased (+0.3%) to 91.304% when pulling 4a9e812 on victormartinelicocorp:2_business_requirement_deliverable_categ into a598784 on OCA:8.0.

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 13, 2016

@gurneyalex Could you help with Runbot: https://runbot.odoo-community.org/runbot/build/3154237 ?
I force Rebuild but seems not working.

cc @elicoidal

@gurneyalex

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

@victormartinelicocorp it was a postgresql issue. I restarted the database, things should be better now.

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 14, 2016

@sbidoul sbidoul removed the Needs Review label Sep 15, 2016

@dreispt

This comment has been minimized.

Copy link
Member

commented Sep 15, 2016

👍 LGTM

@dreispt dreispt changed the title [WIP] business_requirement_deliverable_categ [ADD] business_requirement_deliverable_categ Sep 15, 2016

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2016

👍

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2016

@victormartinelicocorp please merge first my PR one your fork for the README

Victor Martin
Merge pull request #30 from elicoidal/2_business_requirement_delivera…
…ble_categ

Cleansed the README+__openerp__.py
@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 18, 2016

@victormartinelicocorp please merge first my PR one your fork for the README

@elicoidal Done

@victormmtorres

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 18, 2016

Could be merged?
@elicoidal @dreispt

@elicoidal

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2016

Normally the rule is 2 👍 and 5 days delay or 3 :+1 for immediate merge.

If nobody reacts, we normally merge in 2 days

@elicoidal elicoidal merged commit 6bbfa18 into OCA:8.0 Sep 30, 2016

5 checks passed

ci/runbot runbot build 3154740-4-d68d55 (runtime 61s)
Details
codecov/patch 100% of diff hit (target 90.99%)
Details
codecov/project 92.00% (+1.00%) compared to a598784
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.009%) to 92.0%
Details

elicoidal added a commit that referenced this pull request Oct 4, 2016

RawEvan pushed a commit to RawEvan/business-requirement that referenced this pull request Oct 9, 2016

Merge pull request OCA#4 from astirpe/patch-2
Flake8: openerp.api not used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.