[8.0][IMP] Partial Payments #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbcosta
force-pushed
the
8.0-partial_payments
branch
3 times, most recently
from
fd156c0
to
9938445
Compare
pedrobaeza
requested changes
Dec 27, 2016
sale_commission/__openerp__.py
Outdated
| @@ -31,7 +31,8 @@ | |||
| "Daniel Campos <danielcampos@avanzosc.es>", | |||
| "Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>", | |||
| "Oihane Crucelaegui <oihanecruce@gmail.com>", | |||
| "Iván Todorovich <ivan.todorovich@gmail.com", | |||
| "Iván Todorovich <ivan.todorovich@gmail.com" | |||
| @@ -172,8 +179,11 @@ class SettlementLine(models.Model): | |||
| comodel_name="res.partner", readonly=True, related="agent_line.agent", | |||
| store=True) | |||
| settled_amount = fields.Float( | |||
| related="agent_line.amount", readonly=True, store=True) | |||
| string='Settled Amount', digits_compute=dp.get_precision('Account')) | |||
There was a problem hiding this comment.
Why removing this related field?
There was a problem hiding this comment.
Hi @pedrobaeza, thank you for review, the reason is the related field has the total value to be paid to commission but now with partial payments this field can't be the same because here the value can be 30%, 50% etc depending the prorportional of what was paid in invoice
sale_commission/models/settlement.py
Outdated
| @@ -14,7 +15,9 @@ class Settlement(models.Model): | |||
| def _default_currency(self): | |||
| return self.env.user.company_id.currency_id.id | |||
|
|
|||
| total = fields.Float(compute="_compute_total", readonly=True, store=True) | |||
| total = fields.Float( | |||
| compute="_compute_total", readonly=True, store=True, | |||
There was a problem hiding this comment.
A compute field is already readonly without inverse function.
sale_commission/models/settlement.py
Outdated
| effective_date = fields.Date( | ||
| string="Effective date", | ||
| help="In case of commission type is based in Payments use this date" | ||
| " in case of based in Invoice use invoice date.") |
There was a problem hiding this comment.
Add dots and commas to the redaction of the help.
mbcosta
force-pushed
the
8.0-partial_payments
branch
from
b37dbf6
to
34aaf60
Compare
mbcosta
force-pushed
the
8.0-partial_payments
branch
2 times, most recently
from
6264775
to
cfd5563
Compare
…ecision Account in fields Float, configure Report to use the right date depends on commission type and add Akretion as Contributors.
…the same line of commission.
…e same as in Settlement, proccess of Cancel Invoice and Settlement and unlink Settlement.
mbcosta
force-pushed
the
8.0-partial_payments
branch
from
cfd5563
to
5fc4e82
Compare
mbcosta
force-pushed
the
8.0-partial_payments
branch
from
5fc4e82
to
d6474b8
Compare
|
There are conflicting files and this is very old. I'm going to close it. If you still see this as needed, please fix the conflicts and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases of use the company make sells with Payment Terms like this two times in 07 and 28 days or three times in 30, 60, 90 days, the commission was paid or with Invoice created or after all Invoice is Paid, I included other option after the first Partial Payments we can create the Settlement with value based in the same percentage was paid. Example:
Total Invoice = 20000
Two Payments = 10000 after 7 days and 10000 after 28 days
Total Commission = 4000
After make the first payment
Total of Settlement need to be = 2000
And after second payment
Total of Settlement need to be = 2000