New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] [8.0] sale_commission: Add settlement menu view for sale_manager #126

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@Daniel-CA
Contributor

Daniel-CA commented Jul 19, 2017

No description provided.

@Daniel-CA Daniel-CA changed the title from [IMP] sale_commssion: Add settlement menu view for sale_manager to [IMP] sale_commission: Add settlement menu view for sale_manager Jul 19, 2017

@Daniel-CA Daniel-CA changed the title from [IMP] sale_commission: Add settlement menu view for sale_manager to [IMP] [8.0] sale_commission: Add settlement menu view for sale_manager Jul 19, 2017

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

I was thinking to add a wizard to merge all settlements for a same agent and period in one so it can be invoiced all lines together (I know that it can be done using invoice_merge later on) but this is a cleaner way.

Contributor

Daniel-CA commented Jul 19, 2017

I was thinking to add a wizard to merge all settlements for a same agent and period in one so it can be invoiced all lines together (I know that it can be done using invoice_merge later on) but this is a cleaner way.

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jul 19, 2017

Contributor

You must do only one settlement per period. If not, remove the previous settlements. Any way, this mustn't be done here.

Contributor

pedrobaeza commented Jul 19, 2017

You must do only one settlement per period. If not, remove the previous settlements. Any way, this mustn't be done here.

@pedrobaeza pedrobaeza closed this Jul 19, 2017

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

Sorry, I posted before finishing the post.
The main problem is currently a new settlement is created for every account.invoice.line.agent

Contributor

Daniel-CA commented Jul 19, 2017

Sorry, I posted before finishing the post.
The main problem is currently a new settlement is created for every account.invoice.line.agent

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jul 19, 2017

Contributor

Do you mean for each different agent? That's the expected result.

Contributor

pedrobaeza commented Jul 19, 2017

Do you mean for each different agent? That's the expected result.

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

No, it happens for the same agent too.

Contributor

Daniel-CA commented Jul 19, 2017

No, it happens for the same agent too.

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jul 19, 2017

Contributor

Well, that's not what happens normally. This is a bug then, not a feature. Please fix it instead.

Contributor

pedrobaeza commented Jul 19, 2017

Well, that's not what happens normally. This is a bug then, not a feature. Please fix it instead.

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

👍

Contributor

Daniel-CA commented Jul 19, 2017

👍

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

@pedrobaeza I just want to know why this improvement is not valid. A lot of people is used to using tree views rather than reports, thanks.

Contributor

Daniel-CA commented Jul 19, 2017

@pedrobaeza I just want to know why this improvement is not valid. A lot of people is used to using tree views rather than reports, thanks.

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jul 19, 2017

Contributor

Sorry, I mixed the concepts (but because you mixed previously the concept of the PR with the other thing about merging settlements).

Contributor

pedrobaeza commented Jul 19, 2017

Sorry, I mixed the concepts (but because you mixed previously the concept of the PR with the other thing about merging settlements).

@pedrobaeza pedrobaeza reopened this Jul 19, 2017

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Jul 19, 2017

Contributor

Ok, thanks. 😆

Contributor

Daniel-CA commented Jul 19, 2017

Ok, thanks. 😆

@Daniel-CA

This comment has been minimized.

Show comment
Hide comment
@Daniel-CA

Daniel-CA Oct 2, 2017

Contributor

Can this view improvement be merged?

Contributor

Daniel-CA commented Oct 2, 2017

Can this view improvement be merged?

@oihane

oihane approved these changes Oct 3, 2017

LGTM

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Oct 9, 2017

Contributor

Can you please backport it to newer versions?

Contributor

pedrobaeza commented Oct 9, 2017

Can you please backport it to newer versions?

@pedrobaeza pedrobaeza merged commit e45743a into OCA:8.0 Oct 9, 2017

3 checks passed

ci/runbot runbot build 3304970-126-74fdbd (runtime 2010s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.81%
Details

@Daniel-CA Daniel-CA deleted the Daniel-CA:sale_commision branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment