[MIG] Migrated base_phone to v10.0 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work. We still have to fix one think: in the URL "tel:+33141984242", the spaces/non-breaking-spaces are still there ; they should be removed. Once it is fixed, it can be merged: 👍 |
Garamotte
force-pushed
the
10.0-migrate-base_phone
branch
3 times, most recently
from
a5f4a3b
to
ce1ca23
Compare
|
Number format in the link fixed. I also added a new commit, to define Phone and Fax as real field types. |
|
@sylvain-garancher It's great that you found a solution to avoid inheriting the views to add widget="phone" or widget="fax"... something I wanted to do for a long time (or at least since v9). I tried your latest code, but when I try to access the form view of a partner, I get a JS error |
added 3 commits
October 15, 2016 19:08
Garamotte
force-pushed
the
10.0-migrate-base_phone
branch
from
ce1ca23
to
6f1dc6b
Compare
|
Oops, sorry, I forgot to test with empty values :) I added another change : The phone field now inherits from fax, as it has the same behaviour, plus the clcik2dial feature. This avoids duplicated code between the two field types and widgets. |
|
Works very well now ! 👍 |
pedrobaeza
reviewed
Oct 16, 2016
| - if [ -d /home/travis/${ODOO_REPO##*/}-${VERSION}/addons ]; then ln -s ${HOME}/web_action_request/web_action_request /home/travis/${ODOO_REPO##*/}-${VERSION}/addons; fi | ||
| - hg clone http://bitbucket.org/anybox/bus_enhanced -b ${VERSION} ${HOME}/bus_enhanced | ||
| - if [ -d /home/travis/${ODOO_REPO##*/}-${VERSION}/addons ]; then ln -s ${HOME}/bus_enhanced/bus_enhanced /home/travis/${ODOO_REPO##*/}-${VERSION}/addons; fi | ||
| # - hg clone http://bitbucket.org/anybox/web_action_request -b ${VERSION} ${HOME}/web_action_request |
There was a problem hiding this comment.
We should directly remove these lines.
pedrobaeza
approved these changes
Oct 16, 2016
Garamotte
force-pushed
the
10.0-migrate-base_phone
branch
from
6f1dc6b
to
fd43c27
Compare
|
Commented lines removed in TavisCI configuration. |
mamcode
pushed a commit
to druidoo-dev/connector-telephony
that referenced
this pull request
Apr 16, 2020
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
mimusica
pushed a commit
to mimusica/connector-telephony
that referenced
this pull request
Aug 2, 2020
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
mimusica
pushed a commit
to mimusica/connector-telephony
that referenced
this pull request
Aug 5, 2020
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
PierrickBrun
pushed a commit
to akretion/connector-telephony
that referenced
this pull request
Dec 7, 2020
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
cvinh
pushed a commit
to invitu/connector-telephony
that referenced
this pull request
Mar 27, 2021
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
PierrickBrun
pushed a commit
to akretion/connector-telephony
that referenced
this pull request
May 3, 2021
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
PierrickBrun
pushed a commit
to akretion/connector-telephony
that referenced
this pull request
May 4, 2021
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
Aldeigja
pushed a commit
to cetmix/oca-connector-telephony
that referenced
this pull request
Dec 21, 2022
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
mmequignon
pushed a commit
to mmequignon/connector-telephony
that referenced
this pull request
Jan 17, 2023
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
hunghn
pushed a commit
to hunghn/connector-telephony
that referenced
this pull request
Feb 22, 2023
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
nguyenminhchien
pushed a commit
to nguyenminhchien/connector-telephony
that referenced
this pull request
Mar 16, 2023
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
aiendry-aktivsoftware
pushed a commit
to aiendry-aktivsoftware/connector-telephony
that referenced
this pull request
May 1, 2023
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
Aldeigja
pushed a commit
to cetmix/oca-connector-telephony
that referenced
this pull request
May 18, 2023
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
Nikul-OSI
pushed a commit
to ursais/connector-telephony
that referenced
this pull request
Feb 12, 2024
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
OCA-git-bot
pushed a commit
to hailangvn2023/connector-telephony
that referenced
this pull request
Feb 13, 2024
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
luisDIXMIT
pushed a commit
to dixmit/connector-telephony
that referenced
this pull request
Apr 3, 2024
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
luisDIXMIT
pushed a commit
to dixmit/connector-telephony
that referenced
this pull request
Apr 4, 2024
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
luisDIXMIT
pushed a commit
to dixmit/connector-telephony
that referenced
this pull request
Apr 11, 2024
[MIG] Migrated base_phone to v10.0 * Define Phone and Fax as real field types, to avoid the need of defining the widget on each view * [IMP] Add missing ImportError checks for the phonenumbers module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes about the migration :