New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mock_job_delay_to_direct' to ease tests on jobs #123

Merged
merged 1 commit into from Oct 23, 2015

Conversation

Projects
None yet
3 participants
@guewen
Member

guewen commented Oct 1, 2015

This context manager allows to execute a job function synchronously when it
should normally have been delayed in a asynchronous job.

This is really useful for writing tests that check the flow of a
synchronisation without having to deal with the jobs execution mechanisms.

It is used in the OCA/connector-magento project and ought to be used by other
projects.

@guewen guewen changed the title from Add 'mock_job_delay_to_direct' for tests purposes to Add 'mock_job_delay_to_direct' to ease tests on jobs Oct 1, 2015

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon Oct 1, 2015

Contributor

👍 now I must clean my tests ☺

Contributor

lmignon commented Oct 1, 2015

👍 now I must clean my tests ☺

@laetitia-gangloff

This comment has been minimized.

Show comment
Hide comment
@laetitia-gangloff

laetitia-gangloff commented Oct 13, 2015

👍 nice !

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon Oct 23, 2015

Contributor

@guewen Can you rebase?

Contributor

lmignon commented Oct 23, 2015

@guewen Can you rebase?

Add 'mock_job_delay_to_direct' to ease tests on jobs
This context manager allows to execute a job function synchronously when it
should normally have been delayed in a asynchronous job.

This is really useful for writing tests that check the flow of a
synchronisation without having to deal with the jobs execution mechanisms.

It is used in the OCA/connector-magento project and ought to be used by other
projects.
@guewen

This comment has been minimized.

Show comment
Hide comment
@guewen

guewen Oct 23, 2015

Member

Done

On Fri, Oct 23, 2015 at 8:39 AM, Laurent Mignon (ACSONE) <
notifications@github.com> wrote:

@guewen https://github.com/guewen Can you rebase?


Reply to this email directly or view it on GitHub
#123 (comment).

Member

guewen commented Oct 23, 2015

Done

On Fri, Oct 23, 2015 at 8:39 AM, Laurent Mignon (ACSONE) <
notifications@github.com> wrote:

@guewen https://github.com/guewen Can you rebase?


Reply to this email directly or view it on GitHub
#123 (comment).

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon Oct 23, 2015

Contributor

Thank you @guewen. The PR will be merged once travis will be green.

Contributor

lmignon commented Oct 23, 2015

Thank you @guewen. The PR will be merged once travis will be green.

lmignon added a commit that referenced this pull request Oct 23, 2015

Merge pull request #123 from guewen/connector-add-mock_job_delay_to_d…
…irect

Add 'mock_job_delay_to_direct' to ease tests on jobs

@lmignon lmignon merged commit 7a277b5 into OCA:8.0 Oct 23, 2015

2 checks passed

ci/runbot runbot build 3118107-123-decde3 (runtime 31s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guewen

This comment has been minimized.

Show comment
Hide comment
@guewen

guewen Oct 23, 2015

Member

Thanks

Member

guewen commented Oct 23, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment