New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define seconds and ignore retries when raising RetryableJobError #124

Merged
merged 3 commits into from Oct 16, 2015

Conversation

Projects
None yet
5 participants
@guewen
Member

guewen commented Oct 6, 2015

The job will be retried after the given number of seconds if the exception is
raised with a defined 'seconds' argument.

@guewen guewen changed the title from Allow to set define seconds for a RetryableJobError to Allow to define seconds for a RetryableJobError Oct 6, 2015

@guewen guewen changed the title from Allow to define seconds for a RetryableJobError to Allow to define seconds when raising RetryableJobError Oct 6, 2015

guewen added some commits Oct 6, 2015

Allow to define seconds when raising RetryableJobError
The job will be retried after the given number of seconds if the exception is
raised with a defined 'seconds' argument.
@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon Oct 6, 2015

Contributor

Good Idea! The tests need to be fixed.

Contributor

lmignon commented Oct 6, 2015

Good Idea! The tests need to be fixed.

@guewen guewen changed the title from Allow to define seconds when raising RetryableJobError to Allow to define seconds and ignore retries when raising RetryableJobError Oct 7, 2015

@guewen guewen added the needs review label Oct 7, 2015

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon Oct 7, 2015

Contributor

👍 (Code review) Thank you @guewen

Contributor

lmignon commented Oct 7, 2015

👍 (Code review) Thank you @guewen

@gurneyalex

This comment has been minimized.

Show comment
Hide comment
@gurneyalex

gurneyalex Oct 15, 2015

Member

👍

Member

gurneyalex commented Oct 15, 2015

👍

@sebalix

This comment has been minimized.

Show comment
Hide comment
@sebalix

sebalix Oct 15, 2015

Great, I need this feature currently, 👍

sebalix commented Oct 15, 2015

Great, I need this feature currently, 👍

lmignon added a commit that referenced this pull request Oct 16, 2015

Merge pull request #124 from guewen/retryable-exception-seconds
Allow to define seconds and ignore retries when raising RetryableJobError

@lmignon lmignon merged commit 48445f0 into OCA:8.0 Oct 16, 2015

2 checks passed

ci/runbot runbot build 3116590-124-51ee1c (runtime 31s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yvaucher yvaucher removed the needs review label Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment