Check if a module is installed from the registry #130

Merged
merged 1 commit into from Oct 15, 2015

Conversation

Projects
None yet
6 participants
@guewen
Member

guewen commented Oct 15, 2015

Instead of ir.module.module. Simplifies as we never hit the database nor have
to maintain a cache.

Also, it fixes an issue when we run tests directly at the installation of a
module, during the tests the previous implementation was considering the module
as uninstalled instead of installed.

Change proposed by @bealdav. Thanks!

Fixes #85

Check if a module is installed from the registry
Instead of `ir.module.module`. Simplifies as we never hit the database nor have
to maintain a cache.

Also, it fixes an issue when we run tests directly at the installation of a
module, during the tests the previous implementation was considering the module
as uninstalled instead of installed.

Change proposed @bealdav. Thanks!

Fixes #85
@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Oct 15, 2015

Contributor

👍

Contributor

pedrobaeza commented Oct 15, 2015

👍

@gurneyalex

This comment has been minimized.

Show comment
Hide comment
@gurneyalex

gurneyalex Oct 15, 2015

Member

nice 👍

Member

gurneyalex commented Oct 15, 2015

nice 👍

@sebalix

This comment has been minimized.

Show comment
Hide comment

sebalix commented Oct 15, 2015

👍

@bealdav

This comment has been minimized.

Show comment
Hide comment
@bealdav

bealdav Oct 15, 2015

Contributor

thanks @guewen to do this PR instead of me. I like when you remove code.
It seems to me when I read, that I'm better than I'm in reality ;-)
1 line remove 30 lines, nice
👍

Contributor

bealdav commented Oct 15, 2015

thanks @guewen to do this PR instead of me. I like when you remove code.
It seems to me when I read, that I'm better than I'm in reality ;-)
1 line remove 30 lines, nice
👍

@sebastienbeau

This comment has been minimized.

Show comment
Hide comment
Member

sebastienbeau commented Oct 15, 2015

👍

sebastienbeau added a commit that referenced this pull request Oct 15, 2015

Merge pull request #130 from guewen/is_installed-registry
Check if a module is installed from the registry

@sebastienbeau sebastienbeau merged commit 782ee75 into OCA:8.0 Oct 15, 2015

2 checks passed

ci/runbot runbot build 3117503-130-2790b8 (runtime 32s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guewen

This comment has been minimized.

Show comment
Hide comment
@guewen

guewen Oct 15, 2015

Member

thanks @guewen to do this PR instead of me. I like when you remove code.
It seems to me when I read, that I'm better than I'm in reality ;-)
1 line remove 30 lines, nice

It is all yours yet!

Member

guewen commented Oct 15, 2015

thanks @guewen to do this PR instead of me. I like when you remove code.
It seems to me when I read, that I'm better than I'm in reality ;-)
1 line remove 30 lines, nice

It is all yours yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment