New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to assign a default channel on @job functions #71

Merged
merged 2 commits into from May 27, 2015

Conversation

Projects
None yet
5 participants
@guewen
Member

guewen commented May 27, 2015

When the @job is registered and created in the database, it lookups its
channel and creates it if it don't exist yet.

Allows to do:

@job(default_channel='root.channel.subchannel')
def a_task(session, arg):
    pass

Also add tests on jobs and channels models

guewen added some commits Apr 24, 2015

Allow to assign a default channel on @job functions
When the @job is registered and created in the database, it lookups its channel
and creates it if it don't exist yet.
@guewen

This comment has been minimized.

Show comment
Hide comment
@guewen

guewen May 27, 2015

Member

I thought it was merged in the jobrunner branch but it appears it wasn't. Thus I propose it again on the 8.0 branch.

Member

guewen commented May 27, 2015

I thought it was merged in the jobrunner branch but it appears it wasn't. Thus I propose it again on the 8.0 branch.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 27, 2015

Coverage Status

Coverage increased (+0.56%) to 75.14% when pulling b299b6b on guewen:default-channels-on-jobs into aa5cf84 on OCA:8.0.

Coverage Status

Coverage increased (+0.56%) to 75.14% when pulling b299b6b on guewen:default-channels-on-jobs into aa5cf84 on OCA:8.0.

@sbidoul

This comment has been minimized.

Show comment
Hide comment
@sbidoul

sbidoul May 27, 2015

Member

It must have been lost in the last rebase, sorry.

👍

Member

sbidoul commented May 27, 2015

It must have been lost in the last rebase, sorry.

👍

@guewen

This comment has been minimized.

Show comment
Hide comment
@guewen

guewen May 27, 2015

Member

It must have been lost in the last rebase, sorry.

No problem :-)

Member

guewen commented May 27, 2015

It must have been lost in the last rebase, sorry.

No problem :-)

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon

lmignon May 27, 2015

Contributor

👍

Contributor

lmignon commented May 27, 2015

👍

@yvaucher

This comment has been minimized.

Show comment
Hide comment
@yvaucher

yvaucher May 27, 2015

Member

👍

Member

yvaucher commented May 27, 2015

👍

yvaucher added a commit that referenced this pull request May 27, 2015

Merge pull request #71 from guewen/default-channels-on-jobs
Allow to assign a default channel on @job functions

@yvaucher yvaucher merged commit 9e66233 into OCA:8.0 May 27, 2015

2 checks passed

ci/runbot runbot build 2947460-71-b299b6 (runtime 33s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@guewen guewen deleted the guewen:default-channels-on-jobs branch May 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment