Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] contract_sale #949

Merged
merged 25 commits into from
May 26, 2023
Merged

[16.0][MIG] contract_sale #949

merged 25 commits into from
May 26, 2023

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented May 15, 2023 •
edited
Loading

Migration using oca-port tool
replacing #915

  • git history according to style guide
  • replaced account_analytic_tag_contract_salesman by model_account_analytic_plan_contract_salesman instead of deleting

@CRogos CRogos force-pushed the 16.0-mig-contract_sale branch 8 times, most recently from 8b59103 to c3cd14a Compare May 15, 2023 18:47
@CRogos CRogos marked this pull request as ready for review May 15, 2023 18:56
@JesusValdez96
Copy link

@CRogos reduce commits from OCA bots: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

And check the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

@CRogos
Copy link
Contributor Author

CRogos commented May 17, 2023

@JesusValdez96 could give a short comment if this is the right way or what could be improved (next time)?
image

@JesusValdez96
Copy link

@CRogos change to fixup all commits of oca-transbot, oca-travis, oca-git-bot and oca-ci and pick commit f70ad15 of sbejaoui

Luis M. Ontalba and others added 17 commits May 17, 2023 18:20
[ADD] contract_sale (OCA#104)
c557ad5
@lk-eska
[MIG] contract_sale: Migration to 11.0
de10587
@pedrobaeza
[FIX+IMP] contract_sale: Several things:
62c8889 
* README by fragments
* Adjusted dependency
* Changed root menu XML-ID
@sbejaoui
[MIG] contract_sale: Migration to 12.0
3a32a65
@sbejaoui
[12.0][IMP] - Use sale.group_discount_per_so_line on discount field
ed72031
@mvrodriguez
Added translation using Weblate (Galician)
73ce627
@liweijie0812
Added translation using Weblate (Chinese (Simplified))
c226440
@sbejaoui
[IMP] - Adapt contract sale to contract new views
11a6b79
@ThomasBinsfeld
[REF] Contract Sale: split from analytic account
a89bce0 
[REF] Contract Sale: update translations
@sbejaoui
[12.0][IMP] - sale line linked to contracts must not be invoiced from…
800eb29 
… sale order
@enriquemartin
[12.0][FIX] contract & contract_sale - security fix
7828f20 
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields.
This causes the view to crash when a user without the proper permissions tries to access the res.partner form view.
The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions.
Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Added translation using Weblate (Spanish (Chile))
c751f6a
[IMP] contract: add section and notes in contract line
e05a6e9
@max3903
Translated using Weblate (Spanish (Chile))
da89b6e 
Currently translated at 100.0% (1 of 1 strings)

Translation: contract-12.0/contract-12.0-contract_sale
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
@victoralmau
[IMP] contract_sale: black, isort, prettier
9387d47
@victoralmau
[MIG] contract_sale: Migration to 13.0
2397f5b
@dsolanki-initos
[14.0][MIG] contract_sale
a8f5f81
@JesusValdez96
Copy link

JesusValdez96 commented May 17, 2023 •
edited
Loading

@CRogos LGTM could you announce this PR in Migration to version 16.0?

@CRogos CRogos mentioned this pull request May 22, 2023
Open
13 tasks
@MohamedOsman7
Copy link

LGTM

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration contract_sale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 24, 2023
@rousseldenis rousseldenis mentioned this pull request May 24, 2023
Closed
@CRogos
Copy link
Contributor Author

CRogos commented May 24, 2023

@JesusValdez96 would you add a review approval?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-949-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 439f4ce into OCA:16.0 May 26, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 31cc423. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 16.0-mig-contract_sale branch May 26, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@JesusValdez96 JesusValdez96 JesusValdez96 approved these changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.