[ADD] website_sale_search_autocomplete: New module #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new module to provide autocomplete for E-Commerce search using website_field_autocomplete
lasley
force-pushed
the
release/9.0/website_sale_search_autocomplete
branch
from
b6f38e3
to
034871c
Compare
|
Note that if you actually perform a search, you will get a 500. This is unrelated and reported in #158 |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
eLBati
added a commit
to eLBati/e-commerce
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module utilizes
OCA/website/website_field_autocompleteto add an autocomplete to the search for website_sale.The drawback to the current implementation is that the products autocomplete is being appended into the website search, because there isn't an input specifically for the products search. I'm honestly not sure what other contexts this search is used in, but I'm pretty sure this could have unintended consequences somewhere.
The only thing I can think of is to recreate the input element in this module, but that kind of circumvents the whole centralization of the search field which I think would be a bad choice. Pretty sure there's no such thing as a
mode="primary"for templates to copy like we have in the backend, which would be perfect here.This does work FWIW, so unless someone can point me to some other uses for the search that I'm not considering, this is good for review.