Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] account_invoice_import #727

Closed
wants to merge 120 commits into from

Conversation

yvaucher
Copy link
Member

Replaces #213

alexis-via and others added 30 commits February 21, 2023 17:34
FIX raise error when we don't identify a partner

Update README
Rename test/pdf/ to test/invoices/ to host XML invoices too
…invoice_zugferd (see README.rst for more info)

Move the ZUGFeRD/CII-specific code of account_invoice_import to account_invoice_import_zugferd
Disable test of invoice2data, because this lib is difficult to install
Add support for UBL refunds

If you have an UBL refund that I could use to test, please contact me !
Convert YAML test to unittest
…edicated module account_invoice_import_invoice2data

Update README.rst and headers to latest OCA conventions.
Better key names in the parsed_inv dict
parsed_inv doesn't need to be JSON serializable anymore (small drawback: the invoice is parsed a second time on the second step... but the second step is rarely used)
Move code from account_invoice_import_invoice2data to account_invoice_import
Update REAME and some interface strings about UBL being an ISO standard
Small code changes
…voice dict, cleaner organisation)

Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD)
Now support PDF with embedded UBL XML file
Enable unittests on account_invoice_import_ubl
More absolute xpath in account_invoice_import_ubl instead of relative xpath

WARNING: these are big changes, I may have broken a few details
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes
Add unitests in base_business_document_import
Small code enhancements/simplifications
Code cleanup/minor changes
yvaucher and others added 19 commits February 21, 2023 17:34
Add a hook to inject parsed invoice from othe means than a file
Add a hook for an action on missing partner
A button is added on the Vendor Bill form to import invoices in serie
This button can be accessed through the keyboard shortcut with Alt + M (or an other letter depending on the modules installed on the server
Some countries don't provide tax data in invoices, but invoices
by themselves can have the price included tax. In this case, there will be
attempt to create an adjustment line which leads to increasing total
invoice amount and complete fail.
@yvaucher
Copy link
Member Author

/ocabot migration account_invoice_import

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Feb 21, 2023
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 13.0' and the milestone 13.0, so not possible to add the comment.

@bosd
Copy link
Contributor

bosd commented Mar 3, 2023

@yvaucher You did some improvements on the module in this pr. Are there any commits which can be forward ported to V14?

"website": "https://github.com/OCA/edi",
"depends": [
"account",
"base_iban",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"base_iban",
"edi",
"base_iban",

@bosd
Copy link
Contributor

bosd commented Jun 30, 2023

@yvaucher Can you force push

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@github-actions github-actions bot closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.