New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIG] hr_holidays_compute_days #261

Merged
merged 6 commits into from Oct 12, 2016

Conversation

Projects
None yet
5 participants
@yelizariev
Copy link
Member

yelizariev commented Oct 7, 2016

No description provided.

yelizariev added some commits Oct 7, 2016

[MIG] port to 10.0
hr_holidays_compute_days and hr_public_holidays
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 7, 2016

I will fix lint tomorrow

@yelizariev yelizariev force-pushed the it-projects-llc:10.0-hr_holidays_compute_days-porting-clean branch from 9e316ea to 6966856 Oct 8, 2016

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 8, 2016

@gurneyalex @pedrobaeza Why runbot doesn't start for this PR?

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Oct 9, 2016

There are a lot of pending processes since the branch creation, so it has been even detected. I'm not sure if it will be triggered after all... Let's see if we don't need to restart machine and if needed, forcing push can trigger again the rebuild after the restart.

@pedrobaeza pedrobaeza referenced this pull request Oct 9, 2016

Open

Migration to version 10.0 #259

14 of 58 tasks complete
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 10, 2016

@pedrobaeza I guess cron on runbot is stucked. Check this build for example: https://runbot.odoo-community.org/runbot/build/3156163 -- started testing 2 days ago and still haven't switched to job_20

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 10, 2016

@gurneyalex
https://runbot.odoo-community.org/runbot/static/build/3156163-10-0-2ed61c/logs/job_10_test_base.txt

 > /srv/openerp/instances/openerp-oca-runbot/sandbox/bin/python: can't open file '/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3156163-10-0-2ed61c/bin/openerp-server.py': [Errno 2] No such file or directory
@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Oct 10, 2016

@gurneyalex can you please check runbot to see?

@gurneyalex

This comment has been minimized.

Copy link
Member

gurneyalex commented Oct 10, 2016

I'm looking into this

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 11, 2016

@gurneyalex have you applied this patch? odoo/odoo-extra@5b29b65

@feketemihai

This comment has been minimized.

Copy link
Member

feketemihai commented Oct 11, 2016

@gurneyalex I wanted to rebuild runbot but it's the same, complaining about bin openerp-server.py...strange...

@gurneyalex

This comment has been minimized.

Copy link
Member

gurneyalex commented Oct 11, 2016

@yelizariev @feketemihai can you git commit --amend and git push -f? this should fix the build.

@yelizariev yelizariev force-pushed the it-projects-llc:10.0-hr_holidays_compute_days-porting-clean branch from 0e470cc to 02b82c8 Oct 11, 2016

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 11, 2016

@gurneyalex I have done, but it still doesn't work

@gurneyalex

This comment has been minimized.

Copy link
Member

gurneyalex commented Oct 11, 2016

@yelizariev it took one more round of fixing on my side. It should get better soon. I thank you for your patience 😸

@feketemihai
Copy link
Member

feketemihai left a comment

Otherwise ok, 👍 after onchange on holiday status .

@@ -5,7 +5,6 @@
from openerp import models, fields, api, _
from openerp.exceptions import ValidationError
from dateutil.relativedelta import relativedelta
import math


class HrHolidays(models.Model):

This comment has been minimized.

@feketemihai

feketemihai Oct 12, 2016

Member

@yelizariev Can you please add an onchange method for holiday_status_id, the default view is the calendar view, when you select dates, since the holiday_status_id is not selected and not even in the context, the method is not executed, after you select dates it will open the form view of the holiday where you need to select the holiday_status_id, but the method of computing days is not triggered at tjis change...so if you will not change dates or employee, the resulted number of days will be wrong.

And please add test for the method.

This comment has been minimized.

@yelizariev

This comment has been minimized.

@yelizariev

This comment has been minimized.

@feketemihai

feketemihai Oct 12, 2016

Member

@yelizariev Thanks for the fast reaction, testes on runbot and now it's ok.

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Oct 12, 2016

You need to change README file to put version 10.0 and you should also update it to new the template.

@pedrobaeza pedrobaeza merged commit b76e4ae into OCA:10.0 Oct 12, 2016

3 of 4 checks passed

codecov/patch 84.00% of diff hit (target 88.30%)
Details
ci/runbot runbot build 3269361-261-8b068a (runtime 44s)
Details
codecov/project 88.30% remains the same compared to e3373cb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EBII

This comment has been minimized.

Copy link

EBII commented Aug 11, 2017

you let import in hr_public_holidays.py

from openerp import ... please set as from odoo import ...

regards

hieulucky111 added a commit to hieulucky111/hr that referenced this pull request Oct 12, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

hieulucky111 added a commit to hieulucky111/hr that referenced this pull request Oct 12, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

hieulucky111 added a commit to hieulucky111/hr that referenced this pull request Oct 12, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 12, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 13, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 16, 2017

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Mar 21, 2018

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

oleksandrpaziuk
Merge pull request OCA#261 from yvaucher/opti-docker-img-size
Remove unused PO file to reduce docker image size

pedrobaeza added a commit to Eficent/hr that referenced this pull request Sep 2, 2018

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

pedrobaeza added a commit to Eficent/hr that referenced this pull request Sep 3, 2018

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

Trivedi-Vacha-SerpentCS added a commit to Trivedi-Vacha-SerpentCS/hr that referenced this pull request Sep 28, 2018

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0

Trivedi-Vacha-SerpentCS added a commit to Trivedi-Vacha-SerpentCS/hr that referenced this pull request Sep 28, 2018

[10.0][MIG] hr_holidays_compute_days (OCA#261)
[MIG] hr_public_holidays/hr_holidays_compute_days: port to 10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment