[13.0][FIX] github_connector: Use correct error messages #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message depends on the GH auth method being used. If the user selected a token, there won't be a login to show the error in the exception thrown. This makes the error message adapt to the type of auth chosen. TT30343
pedrobaeza
approved these changes
Jun 8, 2021
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9f0ca70. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message on a failed login depends on the GH auth method being used.
If the user selected a token, there won't be a login to show the error in the exception thrown.
This makes the error message adapt to the type of auth chosen.
@Tecnativa
TT30343
ping @pedrobaeza @CarlosRoca13