Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] document_page: Migration to version 10.0 #120

Merged
merged 6 commits into from Feb 2, 2017
Merged

[MIG] document_page: Migration to version 10.0 #120

merged 6 commits into from Feb 2, 2017

Conversation

max3903
Copy link
Sponsor Member

@max3903 max3903 commented Jan 5, 2017

Depends on #118

@max3903 max3903 self-assigned this Jan 5, 2017
@max3903 max3903 added this to the 10.0 milestone Jan 5, 2017
@pedrobaeza pedrobaeza mentioned this pull request Jan 5, 2017
Closed
12 tasks
hbrunn
hbrunn requested changes Jan 9, 2017
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small nits

document_page/wizard/document_page_create_menu.xml
<field name="name">Create Menu</field>
<field name="model">document.page.create.menu</field>
<field name="arch" type="xml">
<form string="Create Menu" version="7.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the string and version attributes can go away I think

document_page/wizard/document_page_show_diff.xml
<field name="name">Show Difference</field>
<field name="model">wizard.document.page.history.show_diff</field>
<field name="arch" type="xml">
<form string="Difference" version="7.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove string and version attribute

dreispt
dreispt reviewed Jan 10, 2017
View reviewed changes
document_page/__manifest__.py
@@ -43,7 +32,5 @@
'demo': [
'demo/document_page.xml'
],
'installable': False,
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to keep the 'installable': True flag here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who recommends that? I usually ask people to remove keys when set to the default value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special case due to the OCA migrate_branch script that was not covered in the regexp expressions, so it could lead to broken manifest files, but I think @StefanRijnhart fixed it when he adapted the script for v10, so it's no more an issue (but needs confirmation by his part).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the script now detects if the key is not present and adds it in that case. So removing it is harmless.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, keeping the install key makes it much easier to use grep to list installable/non installable modules.
But that is just a personal preference and I won't pick on this then.

document_page/__manifest__.py
@@ -43,7 +32,5 @@
'demo': [
'demo/document_page.xml'
],
'installable': False,
'auto_install': False,
'css': ['static/src/css/document_page.css'],
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a valid manifest key?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not since 7.0

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please replace this by an XML extending the web client assets to add the intended CSS file.

document_page/models/document_page.py
readonly=True)

write_uid = fields.Many2one(
'res.users',
"Last Contributor",
select=True,
index=True,
readonly=True
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question: do we really need to index any or all these these fields?

document_page/views/document_page.xml
</tree>
</field>
</record>
<menuitem name="Pages"
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the top menu ("App") name.
Should we rather name it "Documents" or "Knowledge" ?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max3903 what do you think?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt I am fine with Knowledge.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt I double-checked and this is not the top menu name. It's inheriting from knowledge.menu_document

@pedrobaeza pedrobaeza changed the title [MIG] Migration to version 10.0 [MIG] document_page: Migration to version 10.0 Jan 11, 2017
@max3903
Copy link
Sponsor Member Author

max3903 commented Jan 12, 2017

Thanks for your review everyone. I will fix the module today or tomorrow.

@max3903 max3903 mentioned this pull request Jan 19, 2017
Merged
1 task
@max3903
Copy link
Sponsor Member Author

max3903 commented Jan 20, 2017

I believe everything is fixed here.

lasley
lasley approved these changes Jan 20, 2017
View reviewed changes
Copy link

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline, but nothing major. Code + functional 👍

Looks like there's a warning in Runbot though:

2017-01-19 20:42:19,767 211 WARNING openerp_test odoo.addons.base.ir.ir_model: Creating the ir.model.data group_document_user in module base instead of knowledge.

Curious - is there a reason this security is being created in a module that we don't own?

document_page/README.rst
@@ -40,7 +40,7 @@ Bug Tracker

Bugs are tracked on `GitHub Issues <https://github.com/OCA/Knowledge/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/knowledge/issues/new?body=module:%20document_page%0Aversion:%209.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/knowledge/issues/new?body=module:%20document_page%0Aversion:%2010.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to new readme template

@max3903
Copy link
Sponsor Member Author

max3903 commented Jan 20, 2017

@lasley Good catch! Thanks. All fixed.

StefanRijnhart
StefanRijnhart approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot. Thanks!

@max3903
Copy link
Sponsor Member Author

max3903 commented Feb 1, 2017

@hbrunn Can you update your review here? Thank you!

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 2, 2017

Holger's concerns were fixed. Merging.

@dreispt dreispt merged commit c1c17af into OCA:10.0 Feb 2, 2017
@max3903 max3903 deleted the 10.0-document_page branch February 2, 2017 14:47
fayezqandeel pushed a commit to fayezqandeel/knowledge that referenced this pull request Dec 19, 2017
@fayezqandeel
[MIG] document_page: Migration to version 10.0 (OCA#120)
d991026 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jalzaga pushed a commit to Aselcis-Consulting/knowledge that referenced this pull request Apr 2, 2018
@jalzaga
[MIG] document_page: Migration to version 10.0 (OCA#120)
566a5c0 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jalzaga pushed a commit to Aselcis-Consulting/knowledge that referenced this pull request Apr 6, 2018
@jalzaga
[MIG] document_page: Migration to version 10.0 (OCA#120)
97f3476 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jalzaga pushed a commit to Aselcis-Consulting/knowledge that referenced this pull request Apr 6, 2018
@jalzaga
[MIG] document_page: Migration to version 10.0 (OCA#120)
5a1af13 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jalzaga pushed a commit to Aselcis-Consulting/knowledge that referenced this pull request Apr 6, 2018
@jalzaga
[MIG] document_page: Migration to version 10.0 (OCA#120)
01e855a 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
cubells pushed a commit to Tecnativa/knowledge that referenced this pull request Jun 19, 2018
@cubells
document_page: Migration to version 10.0 (OCA#120)
6900be3 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
GavyMG pushed a commit to vauxoo-dev/knowledge that referenced this pull request Jun 20, 2018
[MIG] document_page: Migration to version 10.0 (OCA#120)
6d205c9 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
GavyMG pushed a commit to vauxoo-dev/knowledge that referenced this pull request Jun 27, 2018
[MIG] document_page: Migration to version 10.0 (OCA#120)
854db60 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
pedrobaeza pushed a commit to Tecnativa/knowledge that referenced this pull request Jun 27, 2018
@pedrobaeza
[MIG] document_page: Migration to version 10.0 (OCA#120)
12bac28 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
josemoralesp pushed a commit to Vauxoo/knowledge that referenced this pull request Jul 9, 2018
@dsabrinarg
[11.0] Branch update from OCA (#10)
5c77a32 
* [UPD] README.rst

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 93.9% (31 of 33 strings)

Translation: knowledge-11.0/knowledge-11.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/

* [ADD] document_page from odoo/7.0

* use new API

* [FIX+IMP] document_page:

* Add dependency to knowledge
* Adding hack in document_page_history to allow calling method that don't exists
* document_page_history don't have _sql attribute
* Filter more fields

* Slovene translations added

* [FIX+IMP] document_page:

* Changed history widget to html.
* Improved views and added followers to pages.
* Updated document_page pot and es translations.
* document_page:^Cissing dependency.

* Translations sync with templates

* [MIG] document_page: Migration to 9.0

* [MIG] document_page: Migration to version 10.0 (OCA#120)

* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user

* [IMP][10.0][document_page] Change Requests and workflow improvements on documents (OCA#155)

* OCA Transbot updated translations from Transifex

* [MIG] document_page: Migration to 11.0

* [MIG] document_page: Migration to 11.0

continue migration

* [UPD] Update document_page.pot

* create document_page_approval module
(../7.0pageapproval/ rev 1)

fix status bar in page approval
(../7.0pageapproval/ rev 2)

change approval workflow in page history and started to add showing approved page in normal page
(../7.0pageapproval/ rev 3)

show last approved content and aproved by
(../7.0pageapproval/ rev 4)

Fix bug on page creation
(../7.0pageapproval/ rev 5)

add status in history tree view
(../7.0pageapproval/ rev 6)

add a need approval field and hide the workflow when no approval needed
(../7.0pageapproval/ rev 7)

add access validation to approval
(../7.0pageapproval/ rev 8)

give rigth to Page aprover group on the page_history model and hide the button for unallowed group thought the security isn't enforced a the orm level
(../7.0pageapproval/ rev 9)

made invisible the prover group when not needed
(../7.0pageapproval/ rev 10)

add email to aprovers group's members
(../7.0pageapproval/ rev 11)

* [IMP] Documentation
[ADD] Translation file + french
[FIX] employee_id field does not exist
[FIX] user_email field deprecated

* [IMP] Split long lines

* [ADD] Images

* Fix pep8

* Set document_page_approval as unported

* Slovene translation added

* [IMP] - Changed string from email template.

* [FIX] - document-page-approval: Fixes OCA#60 url not valid when website module is installed.

* [UPD] prefix versions with 8.0

* [MIG] Make modules uninstallable

* OCA Transbot updated translations from Transifex

* [FIX] remove en.po that was erroneously created by transbot

* [MIG] document_page_approval

* [IMP][10.0][document_page_approval] Change Requests and workflow improvements on documents (OCA#155)

* [FIX] View

* remove obsolete .pot files [ci skip]

* start porting

fix act_draft and minor ui fix

remove unused variables

change order of xml data files

* Comment workflow that cause the error

It should work but further errors could help understand what's going

Commented other necessary part

Add back workflow

Add dependency to knowledge

* [IMP] - Improved views to match document_page improvements.

[IMP] - Added notification to followers when a new version is approved.

* [ADD] - Updated document_page_approval pot and added es translations.

[IMP] - document_page_approval: Updated spanish translation.

* Translations sync with templates

Translations and templates sync

Updated languages

* document_page_approval migration from Odoo 8.0 to Odoo 9.0

Lint error corrected

test improved

lint error corrected in test file

readme corrected

test improved

test of document page history workflow added

CI error corrected

dreipst comment

Migration to new api improved in model's file and data tag remove in xml file

code totally migrate to odoo 9.0 api

* test bug fixed

test error fixed

Lint error improved

* [MIG] Make modules uninstallable

[MIG] Rename manifest files

* [ADD] setup.py

* [MIG] document_page_approval: Migration to 11.0

* [UPD] Update document_page_approval.pot
MiquelRForgeFlow pushed a commit to ForgeFlow/knowledge that referenced this pull request Mar 12, 2019
@MiquelRForgeFlow
[MIG] document_page: Migration to version 10.0 (OCA#120)
f09bd72 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
MiquelRForgeFlow pushed a commit to ForgeFlow/knowledge that referenced this pull request Mar 13, 2019
@MiquelRForgeFlow
[MIG] document_page: Migration to version 10.0 (OCA#120)
6c80e03 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
ernestotejeda pushed a commit to Tecnativa/knowledge that referenced this pull request Nov 7, 2019
@ernestotejeda
[MIG] document_page: Migration to version 10.0 (OCA#120)
d103723 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
ernestotejeda pushed a commit to Tecnativa/knowledge that referenced this pull request Nov 7, 2019
@ernestotejeda
[MIG] document_page: Migration to version 10.0 (OCA#120)
f5a03dd 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
ernestotejeda pushed a commit to Tecnativa/knowledge that referenced this pull request Nov 8, 2019
@ernestotejeda
[MIG] document_page: Migration to version 10.0 (OCA#120)
f9fe691 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
PierrickBrun pushed a commit to akretion/knowledge that referenced this pull request Dec 30, 2020
[MIG] document_page: Migration to version 10.0 (OCA#120)
78a2b2a 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
dzungtran89 pushed a commit to dzungtran89/knowledge that referenced this pull request Feb 22, 2021
@dzungtran89
[MIG] document_page: Migration to version 10.0 (OCA#120)
4f5eb3c 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
filoquin pushed a commit to filoquin/knowledge that referenced this pull request May 30, 2021
@filoquin
[MIG] document_page: Migration to version 10.0 (OCA#120)
85df1f2 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
dzungtran89 pushed a commit to dzungtran89/knowledge that referenced this pull request Jul 6, 2021
@dzungtran89
[MIG] document_page: Migration to version 10.0 (OCA#120)
3c03f8d 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jacob88 pushed a commit to jacob88/knowledge that referenced this pull request Oct 29, 2021
@jacob88
[MIG] document_page: Migration to version 10.0 (OCA#120)
a034f8e 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
BernatPForgeFlow pushed a commit to ForgeFlow/knowledge that referenced this pull request Dec 24, 2021
@BernatPForgeFlow
[MIG] document_page: Migration to version 10.0 (OCA#120)
73eaef0 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
jacob88 pushed a commit to jacob88/knowledge that referenced this pull request Dec 24, 2021
@jacob88
[MIG] document_page: Migration to version 10.0 (OCA#120)
0092d20 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
FernandoRomera pushed a commit to MallorcaSoft/knowledge that referenced this pull request Dec 5, 2022
@FernandoRomera
[MIG] document_page: Migration to version 10.0 (OCA#120)
b862c87 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
yaseentai pushed a commit to yaseentai/knowledge that referenced this pull request Jan 11, 2024
@yaseentai
[MIG] document_page: Migration to version 10.0 (OCA#120)
f7f5c4b 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
Tisho99 pushed a commit to sygel-technology/knowledge that referenced this pull request Mar 19, 2024
@Tisho99
[MIG] document_page: Migration to version 10.0 (OCA#120)
cef9ab2 
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn requested changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@dreispt dreispt dreispt approved these changes

@lasley lasley lasley approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees

@max3903 max3903

Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@max3903 @dreispt @StefanRijnhart @hbrunn @pedrobaeza @lasley