[10.0][ADD] business code and validation

[jarmokortetjarvi]

Adds a business id for partners.
Split to two modules: one just adds the field and other adds validation and formatting.
This way the validation will be optional, and the module can be installed in environments with incorrectly formatted business ids

[coveralls]

Coverage decreased (-1.7%) to 98.333% when pulling 51fa60e on Tawasta:10.0-l10n_fi_business_code into 5aee123 on OCA:10.0.

[coveralls]

Coverage remained the same at 100.0% when pulling 1240cca on Tawasta:10.0-l10n_fi_business_code into 19b1749 on OCA:10.0.

[aisopuro]

My concerns on the previous version of this pull request (#15) were already addressed. This is OK.

[mlaitinen]

Maybe add l10n_fi_business_code and l10n_fi_business_code_validate here too.

[mlaitinen]

I'll take that back. This section is autogenerated: https://raw.githubusercontent.com/OCA/maintainer-quality-tools/master/sample_files/README.md

[mlaitinen]

Maybe remove this modification (edicode) and let OCA bot autogenerate it.

[jarmokortetjarvi]

Done. The auto-generation was the reason why I didn't add the business code -modules in readme.

[mlaitinen]

Is there a reason why all this setup/ stuff is in here? Isn't this something that OCA Bot generates automatically?

[jarmokortetjarvi]

As far as I know, they are autogenerated for https://pypi.org/project/setuptools-odoo/
They seem to be here due to a merge 4627715 from main branch

[mlaitinen]

Ok. Could you remove them from this PR?

[mlaitinen]

@aisopuro Do you know how we could get rid of those commits? I tried to remove them by using interactive rebase but failed miserably.

[aisopuro]

It looks a little hairy. There are some merge commits in there, which could make the whole thing really complicated. Maybe try a reset-"rebase":

1. git checkout -b just-testing 10.0-l10n_fi_business_code
2. git fetch origin
3. git reset --soft origin/10.0 (Assuming origin is the remote pointing to the OCA repository)
4. git add the-things-you-want-here (make sure you don't add any setup/ stuff if it isn't wanted)
5. git commit
6. (check the branch makes sense, then reset --hard your feature branch to point to this fixed branch)
7. git push --force-with-lease

This should "squash" everything so that you only have one commit with the files you want to have. You can also do steps 4 and 5 several times, if you want to have different commits cover different things.

[aisopuro]

@mlaitinen it looks like your review is maybe the only thing holding this back.

[jarmokortetjarvi]

Tried to clean up the commit history. If everything went as planned, it should be identical to the original PR (with fixes of course), but without any ./setup-files.

Pre-cleanup branch for reference https://github.com/Tawasta/l10n-finland/tree/10.0-l10n_fi_business_code_original