[ADD] l10n_fr_naf_ape from community-data-files #3

clonedagain · 2014-12-08T14:45:40Z

Module moved from the OCA repository community-data-files.
First step to fix #1 .
The module works as-is on v8. README file added.

… APE activity

…10n_fr_ape_naf

…ad of relying on search/read

clonedagain · 2014-12-16T10:05:00Z

Updated to include the revision history of the 2 modules which I had neglected to include.

yvaucher · 2014-12-17T17:08:18Z

👍

legalsylvain · 2014-12-18T09:23:26Z

Hi,
Thanks for porting this module. 2 thinks :

It's better to make 2 PR for two modules;
For l10n_eu_nace, I don't see the reason to include an european module into fr localization;

❓ CC : @alexis-via

yvaucher · 2014-12-18T12:47:46Z

@legalsylvain Do you suggest to add an european repository?

legalsylvain · 2014-12-18T12:55:38Z

In fact, if it is a EU project, it will be usefull for german, italian teams.
So, I would like to avoid forking that module into all eu localization.
Other solution is to let this module into community-data-files, it isn't ?
What do you think ?
CC : OCA: @sebastienbeau, @gurneyalex, @alexis-via ...

clonedagain · 2014-12-18T14:39:28Z

The French part extends the EU part so I'd rather have both in the same
repo, otherwise the French part is not installable.
I have no idea what's best, opinions are welcome.

Le 18/12/2014 13:55, Sylvain LE GAL a écrit :

In fact, if it is a EU project, it will be usefull for german, italian
teams.
So, I would like to avoid forking that module into all eu localization.
Other solution is to let this module into community-data-files, it isn't ?
What do you think ?
CC : OCA: @sebastienbeau https://github.com/sebastienbeau,
@gurneyalex https://github.com/gurneyalex, @alexis-via
https://github.com/alexis-via ...

—
Reply to this email directly or view it on GitHub
#3 (comment).

FIX declaration of external deps on l10n_fr_base_location_geonames_import

gurneyalex · 2015-03-04T10:55:06Z

__unported__/l10n_eu_nace/__openerp__.py

+{
+    "name": "European NACE partner categories",
+    "version": "2.0",
+    'author': u'Numérigraphe SARL, Sistheo',


Could you please add "Odoo Community Association (OCA)" to the list of authors?

gurneyalex · 2015-03-05T10:07:55Z

maybe we could use https://github.com/OCA/community-data-files for the l10n_eu_nace addon?

pedrobaeza · 2015-03-05T10:10:37Z

Isn't already there but unported (https://github.com/OCA/community-data-files/tree/8.0/__unported__/l10n_eu_nace)? I think that one should be "OCA level", not localization level.

clonedagain · 2015-03-06T08:06:30Z

Thanks all, I'll update this proposal based on your suggestions.

l10n_eu_nace can live on in community-data-files if it fits more there. I'll add a warning (EDIT: in the description) so interested users can install it.

Pull request to add the module: OCA/l10n-france#3

…d3b54b6' git-subtree-dir: l10n_fr_naf_ape git-subtree-mainline: 840b586 git-subtree-split: 09c25ac

clonedagain · 2015-03-06T11:14:08Z

Done. I've also tested the modules on v8: they work unchanged.

Travis fails here because the community-data-files part is __unported__.
Can someone please review OCA/community-data-files#3 ?

gurneyalex · 2015-03-09T08:32:33Z

l10n_fr_naf_ape/README.rst

+To install this module, you may either:
+
+* download it from the Odoo app store: https://www.odoo.com/apps?search=l10n_eu_nace
+* OR download and install the code of the OCA project *Community data files*: https://github.com/numerigraphe/community-data-files


could you use https://github.com/OCA/community-data-files ?

gurneyalex · 2015-03-09T08:40:24Z

overall 👍 once points above have been resolved

legalsylvain · 2015-03-09T09:03:11Z

Thanks all, I'll update this proposal based on your suggestions.
l10n_eu_nace can live on in community-data-files if it fits more there. I'll add a warning (EDIT: in the description) so interested users can install it.

@clonedagain : Just my PoV, but I think the warning is unecessary. All dependencies are written in Travis File. So information is redundant. It should be usefull if it was a non OCA repository.

legalsylvain · 2015-03-09T09:15:50Z

👍 Code review. No test.
Thanks for porting this module and for the refactoring into to various repositories.

yvaucher · 2015-03-09T10:07:42Z

needs fixing as some remarks from @gurneyalex still needs to be addressed

clonedagain · 2015-03-09T11:30:17Z

Fixed I think, Travis should succeed once OCA/community-data-files#3 gets merged.

clonedagain · 2015-03-13T15:38:12Z

Build passes if you force it: https://travis-ci.org/OCA/l10n-france/builds/54259385
Can we merge please ?

yvaucher · 2015-03-13T16:23:13Z

Travis restarted

[ADD] l10n_fr_naf_ape from community-data-files

yvaucher · 2015-03-13T16:24:22Z

Ok merged

Numerigraphe - Lionel Sausin and others added 10 commits January 4, 2012 14:28

[ADD] l10n_fr_naf_ape: add French official NAF partner categories and…

bb6090a

… APE activity

[REF] add a hint to a server branch containing a usefull feature in l…

2247c60

…10n_fr_ape_naf

[REF] Cosmetics

abaf68f

[MERGE] improvements from the 6.0 branch

20babbe

[IMP] Find NACE categories by identifier rather than by name

97b3b11

[MERGE] improved l10n_fr_naf_ape

e5cf27b

[IMP] Update to v7.0 coding standard

33ad08c

[IMP] PEP8

8c2ac4e

[IMP] Place the NAF field next on the left side of the view

d01d120

[FIX] Force the web client to call name_get() on NAF categories inste…

09c25ac

…ad of relying on search/read

clonedagain force-pushed the 8.0-add-naf-nace branch 2 times, most recently from 5028eb3 to 0824ce2 Compare December 16, 2014 10:03

yvaucher added needs review question labels Jan 16, 2015

alexis-via pushed a commit that referenced this pull request Jan 26, 2015

Merge pull request #3 from akretion/8.0-launchpad-final-final-tuning

5b783ad

FIX declaration of external deps on l10n_fr_base_location_geonames_import

gurneyalex reviewed Mar 4, 2015
View reviewed changes

clonedagain mentioned this pull request Mar 6, 2015

Move l10n_fr_naf_ape elsewhere + migrate l10n_eu_nace OCA/community-data-files#3

Merged

clonedagain pushed a commit to numerigraphe/community-data-files that referenced this pull request Mar 6, 2015

[DEL] move l10n_fr_naf_ape to l10n-france

bb56a70

Pull request to add the module: OCA/l10n-france#3

Add 'l10n_fr_naf_ape/' from commit '09c25aca25720f58e6973d8d46e71b00d…

bda6b5f

…d3b54b6' git-subtree-dir: l10n_fr_naf_ape git-subtree-mainline: 840b586 git-subtree-split: 09c25ac

clonedagain force-pushed the 8.0-add-naf-nace branch 2 times, most recently from b74f7ae to 34bfa65 Compare March 6, 2015 10:45

clonedagain changed the title ~~[ADD] l10n_fr_naf_ape, l10n_eu_nace~~ [ADD] l10n_fr_naf_ape from community-data-files Mar 6, 2015

gurneyalex added 8.0 and removed question labels Mar 9, 2015

gurneyalex reviewed Mar 9, 2015
View reviewed changes

yvaucher added the needs fixing label Mar 9, 2015

Lionel Sausin added 2 commits March 9, 2015 11:41

[IMP] licence + README

3fbb2bf

[FIX] Travis: install community-data-files

f4cf10c

clonedagain force-pushed the 8.0-add-naf-nace branch from 578f318 to 3a823d1 Compare March 9, 2015 10:41

[IMP] typo + translation (FR)

5479dc0

clonedagain force-pushed the 8.0-add-naf-nace branch from 3a823d1 to 5479dc0 Compare March 9, 2015 11:03

clonedagain force-pushed the 8.0-add-naf-nace branch from ace13a0 to 5479dc0 Compare March 13, 2015 15:22

yvaucher removed the needs fixing label Mar 13, 2015

yvaucher added a commit that referenced this pull request Mar 13, 2015

Merge pull request #3 from numerigraphe/8.0-add-naf-nace

f30cddb

[ADD] l10n_fr_naf_ape from community-data-files

yvaucher merged commit f30cddb into OCA:8.0 Mar 13, 2015

yvaucher removed the needs review label Mar 13, 2015

clonedagain deleted the 8.0-add-naf-nace branch March 13, 2015 16:42

antespi mentioned this pull request Apr 17, 2015

Improvements for NACE addons OCA/community-data-files#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] l10n_fr_naf_ape from community-data-files #3

[ADD] l10n_fr_naf_ape from community-data-files #3

clonedagain commented Dec 8, 2014

clonedagain commented Dec 16, 2014

yvaucher commented Dec 17, 2014

legalsylvain commented Dec 18, 2014

yvaucher commented Dec 18, 2014

legalsylvain commented Dec 18, 2014

clonedagain commented Dec 18, 2014

gurneyalex Mar 4, 2015

gurneyalex commented Mar 5, 2015

pedrobaeza commented Mar 5, 2015

clonedagain commented Mar 6, 2015

clonedagain commented Mar 6, 2015

gurneyalex Mar 9, 2015

gurneyalex commented Mar 9, 2015

legalsylvain commented Mar 9, 2015

legalsylvain commented Mar 9, 2015

yvaucher commented Mar 9, 2015

clonedagain commented Mar 9, 2015

clonedagain commented Mar 13, 2015

yvaucher commented Mar 13, 2015

yvaucher commented Mar 13, 2015

[ADD] l10n_fr_naf_ape from community-data-files #3

[ADD] l10n_fr_naf_ape from community-data-files #3

Conversation

clonedagain commented Dec 8, 2014

clonedagain commented Dec 16, 2014

yvaucher commented Dec 17, 2014

legalsylvain commented Dec 18, 2014

yvaucher commented Dec 18, 2014

legalsylvain commented Dec 18, 2014

clonedagain commented Dec 18, 2014

gurneyalex Mar 4, 2015

Choose a reason for hiding this comment

gurneyalex commented Mar 5, 2015

pedrobaeza commented Mar 5, 2015

clonedagain commented Mar 6, 2015

clonedagain commented Mar 6, 2015

gurneyalex Mar 9, 2015

Choose a reason for hiding this comment

gurneyalex commented Mar 9, 2015

legalsylvain commented Mar 9, 2015

legalsylvain commented Mar 9, 2015

yvaucher commented Mar 9, 2015

clonedagain commented Mar 9, 2015

clonedagain commented Mar 13, 2015

yvaucher commented Mar 13, 2015

yvaucher commented Mar 13, 2015