Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][mig]l10n_de_holidays #86

Merged
merged 12 commits into from Sep 22, 2021
Merged

[13.0][mig]l10n_de_holidays #86

merged 12 commits into from Sep 22, 2021

Conversation

hkapatel-initos
Copy link
Contributor

@hkapatel-initos hkapatel-initos commented Aug 12, 2021 •
edited

V12 PR: #76
add oca_dependencies.txt on this module

yweng8111 and others added 11 commits August 12, 2021 10:59
@yweng8111 @hkapatel-initos
[ADD] l10n_de_holidays addon
d6795f8
@oca-travis @hkapatel-initos
[UPD] Update l10n_de_holidays.pot
98ccb87
@OCA-git-bot @hkapatel-initos
[ADD] icon.png
80febaa
@abdounasser202 @hkapatel-initos
[UPD] edit version number from 11 to 12 in manifest file
ba13d87
@abdounasser202 @hkapatel-initos
[UPD] Move hr_holidays_public_generator_de file into l10n_de_holidays
44d69fd 
The file has been deleted from hr_holidays_public when migrating code from 11.0 to 12.0  because it's specific to Germany by allowing us to autogenerate holidays' date for german states
@abdounasser202 @hkapatel-initos
[REM] remove dependency from l10n_de_country_states
d1aad37 
Because in Odoo 12, german states are now defined in the module l10n_de
@abdounasser202 @hkapatel-initos
[IMP] add country id when query states
46f0d87
@abdounasser202 @hkapatel-initos
[FIX] TypeError: strptime() argument 1 must be str, not datetime.date
6d2f909
@abdounasser202 @hkapatel-initos
[FIX] W0102: Dangerous default value [] as argument
0043e9b
@abdounasser202 @hkapatel-initos
[FIX] add _description to avoid warning message
275b339
@hkapatel-initos
[IMP] l10n_de_holidays: black, isort, prettier
5ec1e08
@OCA-git-bot
Copy link
Contributor

Hi @hkapatel-initos! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

@hkapatel-initos hkapatel-initos force-pushed the 13.0-mig-l10n_de_holidays branch 4 times, most recently from 3e3ee4b to bc169d5 Compare August 13, 2021 06:03
@hkapatel-initos
Copy link
Contributor Author

it would be nice if someone reviews here.

@tv-openbig
Copy link
Contributor

@hkapatel-initos
I have checked the functionality.
However i do not know if travis and runbot checks have to be successfull ?
Bildschirmfoto 2021-09-09 um 13 25 05
Bildschirmfoto 2021-09-09 um 13 23 03

@silverf0x0
Copy link

Hi All, what are we missing here? Any help needed?

@hkapatel-initos
Copy link
Contributor Author

Hi All, what are we missing here? Any help needed?

I mention the repo of the dependent modules in l10n_de_holidays/oca dependencies.txt but why Travis is not passed.

@hkapatel-initos
Copy link
Contributor Author

Hello, @tv-openbig Travis is happy so.. it would be nice if could you merge this PR.

@tv-openbig tv-openbig merged commit 5680f41 into OCA:13.0 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hkapatel-initos @OCA-git-bot @tv-openbig @silverf0x0 @yweng8111 @oca-travis @abdounasser202